From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1386) id 009DF384B0CA; Mon, 30 May 2022 09:30:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 009DF384B0CA MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jan Beulich To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-853] x86: correct bmi2_umul3_1's MEM_P() uses X-Act-Checkin: gcc X-Git-Author: Jan Beulich X-Git-Refname: refs/heads/master X-Git-Oldrev: 1b88c61e3749d8da905af1c8efc11002b01bd339 X-Git-Newrev: c89298404071e3b42eb7e2bfbdbaa45573538b53 Message-Id: <20220530093007.009DF384B0CA@sourceware.org> Date: Mon, 30 May 2022 09:30:06 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 May 2022 09:30:07 -0000 https://gcc.gnu.org/g:c89298404071e3b42eb7e2bfbdbaa45573538b53 commit r13-853-gc89298404071e3b42eb7e2bfbdbaa45573538b53 Author: Jan Beulich Date: Mon May 30 11:29:59 2022 +0200 x86: correct bmi2_umul3_1's MEM_P() uses It's pretty clear that the operand numbers in the MEM_P() checks are off by one, perhaps due to a copy-and-paste oversight (unlike in most other places here we're dealing with two outputs). gcc/ * config/i386/i386.md (bmi2_umul3_1): Correct MEM_P() arguments. Diff: --- gcc/config/i386/i386.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md index 602dfa799bf..17bdbd93c4b 100644 --- a/gcc/config/i386/i386.md +++ b/gcc/config/i386/i386.md @@ -8465,7 +8465,7 @@ (zero_extend: (match_dup 3))) (match_operand:QI 4 "const_int_operand" "n"))))] "TARGET_BMI2 && INTVAL (operands[4]) == * BITS_PER_UNIT - && !(MEM_P (operands[1]) && MEM_P (operands[2]))" + && !(MEM_P (operands[2]) && MEM_P (operands[3]))" "mulx\t{%3, %0, %1|%1, %0, %3}" [(set_attr "type" "imulx") (set_attr "prefix" "vex")