From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1643) id 7861F381D490; Wed, 8 Jun 2022 12:45:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7861F381D490 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Thomas Schwinge To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/rust/master] Change Artihmetic Operation to be a cast type operation X-Act-Checkin: gcc X-Git-Author: Philip Herron X-Git-Refname: refs/heads/devel/rust/master X-Git-Oldrev: 03c21a08eb40b71e67da0c8ae83ed2c645fb76a3 X-Git-Newrev: d2dcac6a0bfe6a1ae66b584d231b74bd38fe48fc Message-Id: <20220608124555.7861F381D490@sourceware.org> Date: Wed, 8 Jun 2022 12:45:55 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 12:45:55 -0000 https://gcc.gnu.org/g:d2dcac6a0bfe6a1ae66b584d231b74bd38fe48fc commit d2dcac6a0bfe6a1ae66b584d231b74bd38fe48fc Author: Philip Herron Date: Tue May 10 11:21:12 2022 +0100 Change Artihmetic Operation to be a cast type operation Arithmetic operations like this need a cast to support the range of integer types which are allow here. Fixes #1234 Diff: --- gcc/rust/typecheck/rust-hir-type-check-expr.h | 12 +++++++++++- gcc/testsuite/rust/compile/issue-1234.rs | 4 ++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/gcc/rust/typecheck/rust-hir-type-check-expr.h b/gcc/rust/typecheck/rust-hir-type-check-expr.h index f1dff2cb0f2..b20a048865d 100644 --- a/gcc/rust/typecheck/rust-hir-type-check-expr.h +++ b/gcc/rust/typecheck/rust-hir-type-check-expr.h @@ -555,7 +555,17 @@ public: return; } - infered = lhs->unify (rhs); + switch (expr.get_expr_type ()) + { + case ArithmeticOrLogicalOperator::LEFT_SHIFT: + case ArithmeticOrLogicalOperator::RIGHT_SHIFT: + infered = rhs->cast (lhs); + break; + + default: + infered = lhs->unify (rhs); + break; + } } void visit (HIR::ComparisonExpr &expr) override diff --git a/gcc/testsuite/rust/compile/issue-1234.rs b/gcc/testsuite/rust/compile/issue-1234.rs new file mode 100644 index 00000000000..c6d5932c004 --- /dev/null +++ b/gcc/testsuite/rust/compile/issue-1234.rs @@ -0,0 +1,4 @@ +fn foo() -> u8 { + // { dg-warning "function is never used" "" { target *-*-* } .-1 } + 1u8 << 2u32 +}