public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc/devel/rust/master] Merge #1241
Date: Wed,  8 Jun 2022 12:49:18 +0000 (GMT)	[thread overview]
Message-ID: <20220608124918.AFB42380E190@sourceware.org> (raw)

https://gcc.gnu.org/g:63762cc243c643c10aca7e07dfd6abe9b78748f8

commit 63762cc243c643c10aca7e07dfd6abe9b78748f8
Merge: c7008d3e254 a91b138bbc2
Author: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Date:   Mon May 23 14:28:23 2022 +0000

    Merge #1241
    
    1241: Implement name resolution for the IfLet expression. r=philberty a=antego
    
    Addresses #1177.
    
    Guidance from the ticket #1177:
    
    > You should be able to copy how we do name resolution for the if blocks from that file. Though if let statements add a new binding and scope level so you need to declare the pattern so you should be able to see how that is done from rust-ast-resolve-stmt.
    
    I don't understand how to modify the block expression resolution so that it can handle the `IfLet` expression. For now, I copied the code from the `MatchExpr` resolution. Not sure how to test it either and what is the desired expected result of the name resolution so I just hope that reviewers will spot the errors.
    
    I created this PR in order to get some guidance about how to proceed with it. Thanks!
    
    
    
    Co-authored-by: antego <antego@users.noreply.github.com>

Diff:

 gcc/rust/resolve/rust-ast-resolve-expr.cc | 25 +++++++++++++++++++++++++
 gcc/rust/resolve/rust-ast-resolve-expr.h  |  2 ++
 2 files changed, 27 insertions(+)


                 reply	other threads:[~2022-06-08 12:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220608124918.AFB42380E190@sourceware.org \
    --to=tschwinge@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).