From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1880) id 1E1BC3853558; Wed, 8 Jun 2022 16:24:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1E1BC3853558 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Max Filippov To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-10054] gcc: xtensa: fix PR target/105879 X-Act-Checkin: gcc X-Git-Author: Max Filippov X-Git-Refname: refs/heads/releases/gcc-11 X-Git-Oldrev: 66b1b04bb59fbafb809bfad945c95888b758e719 X-Git-Newrev: ee9cd6d6e504cb67b27b1a5e39f965bafd62653b Message-Id: <20220608162459.1E1BC3853558@sourceware.org> Date: Wed, 8 Jun 2022 16:24:59 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 16:24:59 -0000 https://gcc.gnu.org/g:ee9cd6d6e504cb67b27b1a5e39f965bafd62653b commit r11-10054-gee9cd6d6e504cb67b27b1a5e39f965bafd62653b Author: Max Filippov Date: Tue Jun 7 21:01:01 2022 -0700 gcc: xtensa: fix PR target/105879 split_double operates with the 'word that comes first in memory in the target' terminology, while gen_lowpart operates with the 'value representing some low-order bits of X' terminology. They are not equivalent and must be dealt with differently on little- and big-endian targets. gcc/ PR target/105879 * config/xtensa/xtensa.md (movdi): Rename 'first' and 'second' to 'lowpart' and 'highpart' so that they match 'gen_lowpart' and 'gen_highpart' bitwise semantics and fix order of highpart and lowpart depending on target endianness. (cherry picked from commit e94c6dbfb57a862dd8a8685eabc4886ad1aaea25) Diff: --- gcc/config/xtensa/xtensa.md | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index cdf22f14b94..fabc313197a 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -754,11 +754,14 @@ because of offering further optimization opportunities. */ if (register_operand (operands[0], DImode)) { - rtx first, second; - - split_double (operands[1], &first, &second); - emit_insn (gen_movsi (gen_lowpart (SImode, operands[0]), first)); - emit_insn (gen_movsi (gen_highpart (SImode, operands[0]), second)); + rtx lowpart, highpart; + + if (TARGET_BIG_ENDIAN) + split_double (operands[1], &highpart, &lowpart); + else + split_double (operands[1], &lowpart, &highpart); + emit_insn (gen_movsi (gen_lowpart (SImode, operands[0]), lowpart)); + emit_insn (gen_movsi (gen_highpart (SImode, operands[0]), highpart)); DONE; }