From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 168E83841441; Wed, 15 Jun 2022 11:15:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 168E83841441 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1105] tree-optimization/105969 - FPE with array diagnostics X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: f4c3ce32fa54c1aefac0b3a825d8a3f73de95939 X-Git-Newrev: edb9330c29fe8a0a0b76df6fafd6a223a4d0e41f Message-Id: <20220615111522.168E83841441@sourceware.org> Date: Wed, 15 Jun 2022 11:15:22 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 11:15:22 -0000 https://gcc.gnu.org/g:edb9330c29fe8a0a0b76df6fafd6a223a4d0e41f commit r13-1105-gedb9330c29fe8a0a0b76df6fafd6a223a4d0e41f Author: Richard Biener Date: Wed Jun 15 10:54:48 2022 +0200 tree-optimization/105969 - FPE with array diagnostics For a [0][0] array we have to be careful when dividing by the element size which is zero for the outermost dimension. Luckily the division is only for an overflow check which is pointless for array size zero. 2022-06-15 Richard Biener PR tree-optimization/105969 * gimple-ssa-sprintf.cc (get_origin_and_offset_r): Avoid division by zero in overflow check. * gcc.dg/pr105969.c: New testcase. Diff: --- gcc/gimple-ssa-sprintf.cc | 2 +- gcc/testsuite/gcc.dg/pr105969.c | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/gcc/gimple-ssa-sprintf.cc b/gcc/gimple-ssa-sprintf.cc index 6bd27302213..a888b5ac7d5 100644 --- a/gcc/gimple-ssa-sprintf.cc +++ b/gcc/gimple-ssa-sprintf.cc @@ -2319,7 +2319,7 @@ get_origin_and_offset_r (tree x, HOST_WIDE_INT *fldoff, HOST_WIDE_INT *fldsize, if (byteoff < HOST_WIDE_INT_MAX && elbytes < HOST_WIDE_INT_MAX - && byteoff / elbytes == idx) + && (elbytes == 0 || byteoff / elbytes == idx)) { /* For in-bounds constant offsets into constant-sized arrays bump up *OFF, and for what's likely arrays or structs of diff --git a/gcc/testsuite/gcc.dg/pr105969.c b/gcc/testsuite/gcc.dg/pr105969.c new file mode 100644 index 00000000000..52c63fc2efe --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr105969.c @@ -0,0 +1,13 @@ +/* { dg-do compile } */ +/* { dg-options "-Wall" } */ + +struct A +{ + char a[0][0][0]; +}; +extern struct A b[][2]; +void f (void) +{ + __builtin_sprintf (b[0][0].a[1][0], "%s", b[0][0].a[1][0]); /* { dg-warning "past the end" } */ + /* { dg-warning "overlaps destination" "" { target *-*-* } .-1 } */ +}