From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 96669385C32F; Wed, 15 Jun 2022 11:15:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96669385C32F MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1106] tree-optimization/105971 - less surprising refs_may_alias_p_2 X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: edb9330c29fe8a0a0b76df6fafd6a223a4d0e41f X-Git-Newrev: 8c2733e16ec1c0cdda3db4cdc5ad158a96a658e8 Message-Id: <20220615111527.96669385C32F@sourceware.org> Date: Wed, 15 Jun 2022 11:15:27 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 11:15:27 -0000 https://gcc.gnu.org/g:8c2733e16ec1c0cdda3db4cdc5ad158a96a658e8 commit r13-1106-g8c2733e16ec1c0cdda3db4cdc5ad158a96a658e8 Author: Richard Biener Date: Wed Jun 15 11:27:31 2022 +0200 tree-optimization/105971 - less surprising refs_may_alias_p_2 When DSE asks whether __real a is using __imag a it gets a surprising result when a is a FUNCTION_DECL. The following makes sure this case is less surprising to callers but keeping the bail-out for the non-decl case where it is true that PTA doesn't track aliases to code correctly. 2022-06-15 Richard Biener PR tree-optimization/105971 * tree-ssa-alias.cc (refs_may_alias_p_2): Put bail-out for FUNCTION_DECL and LABEL_DECL refs after decl-decl disambiguation to leak less surprising alias results. * gcc.dg/torture/pr106971.c: New testcase. Diff: --- gcc/testsuite/gcc.dg/torture/pr106971.c | 12 ++++++++++++ gcc/tree-ssa-alias.cc | 18 +++++++++--------- 2 files changed, 21 insertions(+), 9 deletions(-) diff --git a/gcc/testsuite/gcc.dg/torture/pr106971.c b/gcc/testsuite/gcc.dg/torture/pr106971.c new file mode 100644 index 00000000000..33f21056e62 --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr106971.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ + +void a() +{ + int b; + int c; + int d = (__INTPTR_TYPE__)a; + _Complex float *e = (_Complex float *)a; + for (;;) { + (*e += d) / b ?: 0; + } +} diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc index 063f1893851..b1e7a2d5afc 100644 --- a/gcc/tree-ssa-alias.cc +++ b/gcc/tree-ssa-alias.cc @@ -2397,15 +2397,6 @@ refs_may_alias_p_2 (ao_ref *ref1, ao_ref *ref2, bool tbaa_p) || CONSTANT_CLASS_P (base2)) return false; - /* We can end up referring to code via function and label decls. - As we likely do not properly track code aliases conservatively - bail out. */ - if (TREE_CODE (base1) == FUNCTION_DECL - || TREE_CODE (base1) == LABEL_DECL - || TREE_CODE (base2) == FUNCTION_DECL - || TREE_CODE (base2) == LABEL_DECL) - return true; - /* Two volatile accesses always conflict. */ if (ref1->volatile_p && ref2->volatile_p) @@ -2432,6 +2423,15 @@ refs_may_alias_p_2 (ao_ref *ref1, ao_ref *ref2, bool tbaa_p) ref2ref, base2, offset2, max_size2, ref2->size); + /* We can end up referring to code via function and label decls. + As we likely do not properly track code aliases conservatively + bail out. */ + if (TREE_CODE (base1) == FUNCTION_DECL + || TREE_CODE (base1) == LABEL_DECL + || TREE_CODE (base2) == FUNCTION_DECL + || TREE_CODE (base2) == LABEL_DECL) + return true; + /* Handle restrict based accesses. ??? ao_ref_base strips inner MEM_REF [&decl], recover from that here. */