From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1035) id 9F1073839C73; Wed, 15 Jun 2022 12:43:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F1073839C73 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Earnshaw To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1108] arm: fix thinko in arm_bfi_1_p() [PR105974] X-Act-Checkin: gcc X-Git-Author: Richard Earnshaw X-Git-Refname: refs/heads/master X-Git-Oldrev: 57b2adae536a6399ed7d2c881b1bc0d4b88e936a X-Git-Newrev: dc8071da0e89eab4935751f3b16745c95cbc0d30 Message-Id: <20220615124348.9F1073839C73@sourceware.org> Date: Wed, 15 Jun 2022 12:43:48 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 12:43:48 -0000 https://gcc.gnu.org/g:dc8071da0e89eab4935751f3b16745c95cbc0d30 commit r13-1108-gdc8071da0e89eab4935751f3b16745c95cbc0d30 Author: Richard Earnshaw Date: Wed Jun 15 13:42:23 2022 +0100 arm: fix thinko in arm_bfi_1_p() [PR105974] I clearly wasn't thinking straight when I wrote the arm_bfi_1_p function and used XUINT rather than UINTVAL when extracting CONST_INT values. It seemed to work in testing, but was incorrect and failed RTL checking. Fixed thusly: gcc/ChangeLog: PR target/105974 * config/arm/arm.cc (arm_bfi_1_p): Use UINTVAL instead of XUINT. Diff: --- gcc/config/arm/arm.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc index 2a76c7b9a72..5aa48fc7664 100644 --- a/gcc/config/arm/arm.cc +++ b/gcc/config/arm/arm.cc @@ -10211,15 +10211,15 @@ arm_bfi_1_p (rtx op0, rtx op1, rtx *sub0, rtx *sub1) if (!CONST_INT_P (XEXP (op0, 1))) return false; - const1 = XUINT (XEXP (op0, 1), 0); + const1 = UINTVAL (XEXP (op0, 1)); if (!CONST_INT_P (XEXP (op1, 1)) - || ~XUINT (XEXP (op1, 1), 0) != const1) + || ~UINTVAL (XEXP (op1, 1)) != const1) return false; if (GET_CODE (XEXP (op0, 0)) == ASHIFT && CONST_INT_P (XEXP (XEXP (op0, 0), 1))) { - const2 = XUINT (XEXP (XEXP (op0, 0), 1), 0); + const2 = UINTVAL (XEXP (XEXP (op0, 0), 1)); *sub0 = XEXP (XEXP (op0, 0), 0); } else