From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1698) id 1FDA43858D32; Wed, 15 Jun 2022 19:16:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FDA43858D32 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Iain D Sandoe To: gcc-cvs@gcc.gnu.org Subject: [gcc r10-10847] Darwin: Future-proof -mmacosx-version-min X-Act-Checkin: gcc X-Git-Author: Mark Mentovai X-Git-Refname: refs/heads/releases/gcc-10 X-Git-Oldrev: b2f5dc82400fe04511b85caa8c80677f81eee415 X-Git-Newrev: f335ab5b77230590618f80f76a5e83626909b8ee Message-Id: <20220615191651.1FDA43858D32@sourceware.org> Date: Wed, 15 Jun 2022 19:16:51 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 19:16:51 -0000 https://gcc.gnu.org/g:f335ab5b77230590618f80f76a5e83626909b8ee commit r10-10847-gf335ab5b77230590618f80f76a5e83626909b8ee Author: Mark Mentovai Date: Fri Jun 10 15:56:42 2022 +0100 Darwin: Future-proof -mmacosx-version-min f18cbc1ee1f4 (2021-12-18) updated various parts of gcc to not impose a Darwin or macOS version maximum of the current known release. Different parts of gcc accept, variously, Darwin version numbers matching darwin2*, and macOS major version numbers up to 99. The current released version is Darwin 21 and macOS 12, with Darwin 22 and macOS 13 expected for public release later this year. With one major OS release per year, this strategy is expected to provide another 8 years of headroom. However, f18cbc1ee1f4 missed config/darwin-c.c (now .cc), which continued to impose a maximum of macOS 12 on the -mmacosx-version-min compiler driver argument. This was last updated from 11 to 12 in 11b967577483 (2021-10-27), but kicking the can down the road one year at a time is not a viable strategy, and is not in line with the more recent technique from f18cbc1ee1f4. Prior to 556ab5125912 (2020-11-06), config/darwin-c.c did not impose a maximum that needed annual maintenance, as at that point, all macOS releases had used a major version of 10. The stricter approach imposed since then was valuable for a time until the particulars of the new versioning scheme were established and understood, but now that they are, it's prudent to restore a more permissive approach. gcc/ChangeLog: * config/darwin-c.c: Make -mmacosx-version-min more future-proof. Signed-off-by: Mark Mentovai (cherry picked from commit 6725f186cb70d48338f69456864bf469a12ee5be) Diff: --- gcc/config/darwin-c.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/config/darwin-c.c b/gcc/config/darwin-c.c index 3c2afe56522..0f746e933c1 100644 --- a/gcc/config/darwin-c.c +++ b/gcc/config/darwin-c.c @@ -691,7 +691,8 @@ macosx_version_as_macro (void) if (!version_array) goto fail; - if (version_array[MAJOR] < 10 || version_array[MAJOR] > 12) + /* System tools accept up to 99 as a major version. */ + if (version_array[MAJOR] < 10 || version_array[MAJOR] > 99) goto fail; if (version_array[MAJOR] == 10 && version_array[MINOR] < 10)