From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1880) id D8A123858281; Sun, 19 Jun 2022 23:25:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D8A123858281 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Max Filippov To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1167] xtensa: Apply a few minor fixes X-Act-Checkin: gcc X-Git-Author: Takayuki 'January June' Suwa X-Git-Refname: refs/heads/master X-Git-Oldrev: 4390e7bfbc641a52c6192b448768dafdf4565527 X-Git-Newrev: 75ab2f0ebd3c6ab678fea03906186068b89f9fbc Message-Id: <20220619232556.D8A123858281@sourceware.org> Date: Sun, 19 Jun 2022 23:25:56 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2022 23:25:57 -0000 https://gcc.gnu.org/g:75ab2f0ebd3c6ab678fea03906186068b89f9fbc commit r13-1167-g75ab2f0ebd3c6ab678fea03906186068b89f9fbc Author: Takayuki 'January June' Suwa Date: Mon Jun 20 04:12:48 2022 +0900 xtensa: Apply a few minor fixes No functional changes. gcc/ChangeLog: * config/xtensa/xtensa.cc (xtensa_emit_move_sequence): Use can_create_pseudo_p(), instead of using individual reload_in_progress and reload_completed. (xtensa_expand_block_set_small_loop): Use xtensa_simm8x256(), the existing predicate function. (xtensa_is_insn_L32R_p, gen_int_relational, xtensa_emit_sibcall): Use the standard RTX code predicate macros such as MEM_P, SYMBOL_REF_P and/or CONST_INT_P. * config/xtensa/xtensa.md: Avoid using numeric literals to determine if callee-saved register, at the split patterns for indirect sibcall fixups. Diff: --- gcc/config/xtensa/xtensa.cc | 16 ++++++++-------- gcc/config/xtensa/xtensa.md | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/gcc/config/xtensa/xtensa.cc b/gcc/config/xtensa/xtensa.cc index c5d00acdf2c..2c534ff9c60 100644 --- a/gcc/config/xtensa/xtensa.cc +++ b/gcc/config/xtensa/xtensa.cc @@ -752,7 +752,7 @@ gen_int_relational (enum rtx_code test_code, /* relational test (EQ, etc) */ } /* See if we need to invert the result. */ - invert = ((GET_CODE (cmp1) == CONST_INT) + invert = (CONST_INT_P (cmp1) ? p_info->invert_const : p_info->invert_reg); @@ -1209,7 +1209,7 @@ xtensa_emit_move_sequence (rtx *operands, machine_mode mode) } } - if (!(reload_in_progress | reload_completed) + if (can_create_pseudo_p () && !xtensa_valid_move (mode, operands)) operands[1] = force_reg (mode, operands[1]); @@ -1612,7 +1612,7 @@ xtensa_expand_block_set_small_loop (rtx *operands) thus limited to only offset to the end address for ADDI/ADDMI instruction. */ if (align == 4 - && ! (bytes <= 127 || (bytes <= 32512 && bytes % 256 == 0))) + && ! (bytes <= 127 || xtensa_simm8x256 (bytes))) return 0; /* If no 4-byte aligned, loop count should be treated as the @@ -2169,7 +2169,7 @@ xtensa_emit_sibcall (int callop, rtx *operands) static char result[64]; rtx tgt = operands[callop]; - if (GET_CODE (tgt) == CONST_INT) + if (CONST_INT_P (tgt)) sprintf (result, "j.l\t" HOST_WIDE_INT_PRINT_HEX ", a9", INTVAL (tgt)); else if (register_operand (tgt, VOIDmode)) @@ -4282,17 +4282,17 @@ xtensa_rtx_costs (rtx x, machine_mode mode, int outer_code, } static bool -xtensa_is_insn_L32R_p(const rtx_insn *insn) +xtensa_is_insn_L32R_p (const rtx_insn *insn) { rtx x = PATTERN (insn); if (GET_CODE (x) == SET) { - x = XEXP (x, 1); - if (GET_CODE (x) == MEM) + x = SET_SRC (x); + if (MEM_P (x)) { x = XEXP (x, 0); - return (GET_CODE (x) == SYMBOL_REF || CONST_INT_P (x)) + return (SYMBOL_REF_P (x) || CONST_INT_P (x)) && CONSTANT_POOL_ADDRESS_P (x); } } diff --git a/gcc/config/xtensa/xtensa.md b/gcc/config/xtensa/xtensa.md index ef6bbc451b0..84b975cf00e 100644 --- a/gcc/config/xtensa/xtensa.md +++ b/gcc/config/xtensa/xtensa.md @@ -1246,14 +1246,14 @@ int i = 0; rtx x = XEXP (operands[1], 0); long l[2]; - if (GET_CODE (x) == SYMBOL_REF + if (SYMBOL_REF_P (x) && CONSTANT_POOL_ADDRESS_P (x)) x = get_pool_constant (x); else if (GET_CODE (x) == CONST) { x = XEXP (x, 0); gcc_assert (GET_CODE (x) == PLUS - && GET_CODE (XEXP (x, 0)) == SYMBOL_REF + && SYMBOL_REF_P (XEXP (x, 0)) && CONSTANT_POOL_ADDRESS_P (XEXP (x, 0)) && CONST_INT_P (XEXP (x, 1))); i = INTVAL (XEXP (x, 1)); @@ -2212,7 +2212,7 @@ (match_operand 1 ""))] "reload_completed && !TARGET_WINDOWED_ABI && SIBLING_CALL_P (insn) - && IN_RANGE (REGNO (operands[0]), 12, 15)" + && ! call_used_or_fixed_reg_p (REGNO (operands[0]))" [(set (reg:SI A10_REG) (match_dup 0)) (call (mem:SI (reg:SI A10_REG)) @@ -2245,7 +2245,7 @@ (match_operand 2 "")))] "reload_completed && !TARGET_WINDOWED_ABI && SIBLING_CALL_P (insn) - && IN_RANGE (REGNO (operands[1]), 12, 15)" + && ! call_used_or_fixed_reg_p (REGNO (operands[1]))" [(set (reg:SI A10_REG) (match_dup 1)) (set (match_dup 0)