From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 6D9D43858C74; Tue, 21 Jun 2022 15:57:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6D9D43858C74 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1190] libgomp: Fix up target-31.c test [PR106045] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: 7905a9ac26707ed6ac49e40e35a9c8755c6574e3 X-Git-Newrev: 85d613da341b76308edea48359a5dbc7061937c4 Message-Id: <20220621155740.6D9D43858C74@sourceware.org> Date: Tue, 21 Jun 2022 15:57:40 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2022 15:57:40 -0000 https://gcc.gnu.org/g:85d613da341b76308edea48359a5dbc7061937c4 commit r13-1190-g85d613da341b76308edea48359a5dbc7061937c4 Author: Jakub Jelinek Date: Tue Jun 21 17:51:08 2022 +0200 libgomp: Fix up target-31.c test [PR106045] The i variable is used inside of the parallel in: #pragma omp simd safelen(32) private (v) for (i = 0; i < 64; i++) { v = 3 * i; ll[i] = u1 + v * u2[0] + u2[1] + x + y[0] + y[1] + v + h[0] + u3[i]; } where i is predetermined linear (so while inside of the body it is safe, private per SIMD lane var) the final value is written to the shared variable, and in: for (i = 0; i < 64; i++) if (ll[i] != u1 + 3 * i * u2[0] + u2[1] + x + y[0] + y[1] + 3 * i + 13 + 14 + i) #pragma omp atomic write err = 1; which is a normal loop and so it isn't in any way privatized there. So we have a data race, fixed by adding private (i) clause to the parallel. 2022-06-21 Jakub Jelinek Paul Iannetta PR libgomp/106045 * testsuite/libgomp.c/target-31.c: Add private (i) clause. Diff: --- libgomp/testsuite/libgomp.c/target-31.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libgomp/testsuite/libgomp.c/target-31.c b/libgomp/testsuite/libgomp.c/target-31.c index 8e63d286b43..1123b7ea561 100644 --- a/libgomp/testsuite/libgomp.c/target-31.c +++ b/libgomp/testsuite/libgomp.c/target-31.c @@ -76,7 +76,7 @@ main () m[1] += 3 * b; } use (&a, &b, &c, &d, e, f, g, h); - #pragma omp parallel firstprivate (u1, u2) + #pragma omp parallel firstprivate (u1, u2) private (i) { int w = omp_get_thread_num (); int x = 19;