From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2122) id 69603385380D; Thu, 23 Jun 2022 15:45:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69603385380D MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jason Merrill To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-8510] c++: -Waddress and value-dependent expr [PR105885] X-Act-Checkin: gcc X-Git-Author: Jason Merrill X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: c600ff8dc5a870d952c9c63fe4fa4535b9f0a488 X-Git-Newrev: b96b64bec37c3dddf1f0f93c27ceb4fd5685c70a Message-Id: <20220623154559.69603385380D@sourceware.org> Date: Thu, 23 Jun 2022 15:45:59 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2022 15:45:59 -0000 https://gcc.gnu.org/g:b96b64bec37c3dddf1f0f93c27ceb4fd5685c70a commit r12-8510-gb96b64bec37c3dddf1f0f93c27ceb4fd5685c70a Author: Jason Merrill Date: Wed Jun 22 23:50:23 2022 -0400 c++: -Waddress and value-dependent expr [PR105885] We already suppress various warnings for code that would be tautological if written directly, but not when it's the result of template substitution. It seems we need to do this for -Waddress as well. PR c++/105885 gcc/cp/ChangeLog: * pt.cc (tsubst_copy_and_build): Also suppress -Waddress for comparison of dependent operands. gcc/testsuite/ChangeLog: * g++.dg/cpp1z/constexpr-if37.C: New test. Diff: --- gcc/cp/pt.cc | 1 + gcc/testsuite/g++.dg/cpp1z/constexpr-if37.C | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+) diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc index 67238000109..e8bf1692c74 100644 --- a/gcc/cp/pt.cc +++ b/gcc/cp/pt.cc @@ -20364,6 +20364,7 @@ tsubst_copy_and_build (tree t, warning_sentinel s2(warn_div_by_zero, was_dep); warning_sentinel s3(warn_logical_op, was_dep); warning_sentinel s4(warn_tautological_compare, was_dep); + warning_sentinel s5(warn_address, was_dep); tree r = build_x_binary_op (input_location, TREE_CODE (t), diff --git a/gcc/testsuite/g++.dg/cpp1z/constexpr-if37.C b/gcc/testsuite/g++.dg/cpp1z/constexpr-if37.C new file mode 100644 index 00000000000..e11e02cfa0e --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1z/constexpr-if37.C @@ -0,0 +1,21 @@ +// PR c++/105885 +// { dg-do compile { target c++17 } } +// { dg-additional-options -Wall } + +int i; + +template +void test() { + if constexpr(ARG == nullptr) { + ++i; + } else { + --i; + } +} + +const char CONSTSTR[] = {'\n', '\t', ' ', '\0'}; + +int main() { + test(); + test(); +}