public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1387] Make sure checking code is conditional in VN Date: Fri, 1 Jul 2022 12:20:53 +0000 (GMT) [thread overview] Message-ID: <20220701122053.BD58D3856DD9@sourceware.org> (raw) https://gcc.gnu.org/g:08ed796ed08996545c574b846f3ca04f2cbe70dc commit r13-1387-g08ed796ed08996545c574b846f3ca04f2cbe70dc Author: Richard Biener <rguenther@suse.de> Date: Fri Jul 1 12:35:58 2022 +0200 Make sure checking code is conditional in VN VN has checking code with gcc_unreachable (), the following makes it cheaper by instead guarding the side-effect with flag_checking. 2022-07-01 Richard Biener <rguenther@suse.de> * tree-ssa-sccvn.cc (vn_nary_op_insert_into): Make checking dominance check conditional on flag_checking. Diff: --- gcc/tree-ssa-sccvn.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/tree-ssa-sccvn.cc b/gcc/tree-ssa-sccvn.cc index 76d92895a3a..c40c45ed840 100644 --- a/gcc/tree-ssa-sccvn.cc +++ b/gcc/tree-ssa-sccvn.cc @@ -4243,9 +4243,10 @@ vn_nary_op_insert_into (vn_nary_op_t vno, vn_nary_op_table_type *table) if (dominated_by_p (CDI_DOMINATORS, vno_bb, val_bb)) /* Value registered with more generic predicate. */ return *slot; - else if (dominated_by_p (CDI_DOMINATORS, val_bb, vno_bb)) + else if (flag_checking) /* Shouldn't happen, we insert in RPO order. */ - gcc_unreachable (); + gcc_assert (!dominated_by_p (CDI_DOMINATORS, + val_bb, vno_bb)); } /* Append value. */ *next = (vn_pval *) obstack_alloc (&vn_tables_obstack,
reply other threads:[~2022-07-01 12:20 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220701122053.BD58D3856DD9@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).