From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id 581F8385C8B2; Fri, 1 Jul 2022 13:21:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 581F8385C8B2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1389] Avoid unused sbitmap in update_ssa X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 2b0937946b19f0f4d91e6248a2806b1f98f5244b X-Git-Newrev: 63abe04999283582b258adf60da6c19d541ebc68 Message-Id: <20220701132159.581F8385C8B2@sourceware.org> Date: Fri, 1 Jul 2022 13:21:59 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jul 2022 13:21:59 -0000 https://gcc.gnu.org/g:63abe04999283582b258adf60da6c19d541ebc68 commit r13-1389-g63abe04999283582b258adf60da6c19d541ebc68 Author: Richard Biener Date: Fri Jul 1 13:59:32 2022 +0200 Avoid unused sbitmap in update_ssa The following avoids copying and using blocks_to_update to the interesting_blocks sbitmap when doing update_ssa as it is unused besides the redundant query in the domwalk. * tree-into-ssa.cc (rewrite_update_dom_walker::before_dom_children): Do not look at interesting_blocks which is a copy of blocks_to_update. (update_ssa): Do not initialize it. (pass_build_ssa::execute): Set interesting_blocks to NULL after releasing it. Diff: --- gcc/tree-into-ssa.cc | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/gcc/tree-into-ssa.cc b/gcc/tree-into-ssa.cc index c4e40e8fb08..c90651c3a89 100644 --- a/gcc/tree-into-ssa.cc +++ b/gcc/tree-into-ssa.cc @@ -2214,15 +2214,11 @@ rewrite_update_dom_walker::before_dom_children (basic_block bb) } /* Step 2. Rewrite every variable used in each statement in the block. */ - if (bitmap_bit_p (interesting_blocks, bb->index)) - { - gcc_checking_assert (bitmap_bit_p (blocks_to_update, bb->index)); - for (gimple_stmt_iterator gsi = gsi_start_bb (bb); !gsi_end_p (gsi); ) - if (rewrite_update_stmt (gsi_stmt (gsi), gsi)) - gsi_remove (&gsi, true); - else - gsi_next (&gsi); - } + for (gimple_stmt_iterator gsi = gsi_start_bb (bb); !gsi_end_p (gsi); ) + if (rewrite_update_stmt (gsi_stmt (gsi), gsi)) + gsi_remove (&gsi, true); + else + gsi_next (&gsi); /* Step 3. Update PHI nodes. */ rewrite_update_phi_arguments (bb); @@ -2460,6 +2456,7 @@ pass_build_ssa::execute (function *fun) free (dfs); sbitmap_free (interesting_blocks); + interesting_blocks = NULL; fini_ssa_renamer (); @@ -3503,15 +3500,8 @@ update_ssa (unsigned update_flags) get_var_info (sym)->info.current_def = NULL_TREE; /* Now start the renaming process at START_BB. */ - interesting_blocks = sbitmap_alloc (last_basic_block_for_fn (cfun)); - bitmap_clear (interesting_blocks); - EXECUTE_IF_SET_IN_BITMAP (blocks_to_update, 0, i, bi) - bitmap_set_bit (interesting_blocks, i); - rewrite_blocks (start_bb, REWRITE_UPDATE); - sbitmap_free (interesting_blocks); - /* Debugging dumps. */ if (dump_file) {