public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Pierre-Marie de Rodat <pmderodat@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1484] [Ada] Fix comments mentioning ancient flags related to objects references Date: Tue, 5 Jul 2022 08:30:13 +0000 (GMT) [thread overview] Message-ID: <20220705083013.C53CE3852740@sourceware.org> (raw) https://gcc.gnu.org/g:074e8addc5d8e92d9446357b961c003fe06dcc50 commit r13-1484-g074e8addc5d8e92d9446357b961c003fe06dcc50 Author: Piotr Trojanek <trojanek@adacore.com> Date: Mon Jun 6 13:02:28 2022 +0200 [Ada] Fix comments mentioning ancient flags related to objects references Flag May_Be_Modified under go a series of renamings between 1996 and 2002. It was changed to Not_Assigned, then to Not_Source_Assigned and finally to Never_Set_In_Source. Fix remaining references in comments. gcc/ada/ * sem_util.ads (Note_Possible_Modification): Fix occurrence of May_Be_Modified in comment. * sem_warn.ads (Check_Unset_Reference): Fix occurrence of Not_Assigned in comment. Diff: --- gcc/ada/sem_util.ads | 2 +- gcc/ada/sem_warn.ads | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/gcc/ada/sem_util.ads b/gcc/ada/sem_util.ads index 4121cf0457a..de7883c2a38 100644 --- a/gcc/ada/sem_util.ads +++ b/gcc/ada/sem_util.ads @@ -2872,7 +2872,7 @@ package Sem_Util is -- This routine is called if the sub-expression N maybe the target of -- an assignment (e.g. it is the left side of an assignment, used as -- an out parameters, or used as prefixes of access attributes). It - -- sets May_Be_Modified in the associated entity if there is one, + -- sets Never_Set_In_Source in the associated entity if there is one, -- taking into account the rule that in the case of renamed objects, -- it is the flag in the renamed object that must be set. -- diff --git a/gcc/ada/sem_warn.ads b/gcc/ada/sem_warn.ads index bcf74aba33c..1894f36f4b0 100644 --- a/gcc/ada/sem_warn.ads +++ b/gcc/ada/sem_warn.ads @@ -86,15 +86,15 @@ package Sem_Warn is -- N is the node for an expression which occurs in a reference position, -- e.g. as the right side of an assignment. This procedure checks to see -- if the node is a reference to a variable entity where the entity has - -- Not_Assigned set. If so, the Unset_Reference field is set if it is not - -- the first occurrence. No warning is posted, instead warnings will be - -- posted later by Check_References. The reason we do things that - -- way is that if there are no assignments anywhere, we prefer to flag - -- the entity, rather than a reference to it. Note that for the purposes - -- of this routine, a type conversion or qualified expression whose - -- expression is an entity is also processed. The reason that we do not - -- process these at the point of occurrence is that both these constructs - -- can occur in non-reference positions (e.g. as out parameters). + -- Never_Set_In_Source set. If so, the Unset_Reference field is set if it + -- is not the first occurrence. No warning is posted, instead warnings will + -- be posted later by Check_References. The reason we do things that way is + -- that if there are no assignments anywhere, we prefer to flag the entity, + -- rather than a reference to it. Note that for the purposes of this + -- routine, a type conversion or qualified expression whose expression is + -- an entity is also processed. The reason that we do not process these + -- at the point of occurrence is that both these constructs can occur in + -- non-reference positions (e.g. as out parameters). procedure Check_Unused_Withs (Spec_Unit : Unit_Number_Type := No_Unit); -- This routine performs two kinds of checks. It checks that all with'ed
reply other threads:[~2022-07-05 8:30 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220705083013.C53CE3852740@sourceware.org \ --to=pmderodat@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).