public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-1502] tree-optimization/106196 - properly update virtual SSA for vector stores
Date: Tue,  5 Jul 2022 10:55:59 +0000 (GMT)	[thread overview]
Message-ID: <20220705105559.608843856DD4@sourceware.org> (raw)

https://gcc.gnu.org/g:1a6e0d8252a71c61d4dc616044fb25b5ac2cfffb

commit r13-1502-g1a6e0d8252a71c61d4dc616044fb25b5ac2cfffb
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Jul 5 10:43:42 2022 +0200

    tree-optimization/106196 - properly update virtual SSA for vector stores
    
    The following properly handles aggregate returns of the const marked
    STORE_LANES internal function to update virtual SSA form on-the-fly
    rather than relying on a costly virtual SSA rewrite.
    
            PR tree-optimization/106196
            * tree-vect-stmts.cc (vect_finish_stmt_generation): Properly
            handle aggregate returns of calls for VDEF updates.
    
            * gcc.dg/torture/pr106196.c: New testcase.

Diff:
---
 gcc/testsuite/gcc.dg/torture/pr106196.c | 14 ++++++++++++++
 gcc/tree-vect-stmts.cc                  |  6 ++++--
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/gcc/testsuite/gcc.dg/torture/pr106196.c b/gcc/testsuite/gcc.dg/torture/pr106196.c
new file mode 100644
index 00000000000..56723de42c2
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr106196.c
@@ -0,0 +1,14 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-ftree-vectorize -fno-vect-cost-model" } */
+
+extern char a[];
+char *b;
+void e() {
+  char *d;
+  int c;
+  d = a;
+  for (; c; c++) {
+    d[2] = d[1] = d[0] = b[c];
+    d += 3;
+  }
+}
diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index 72107afc883..3db6620dd42 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -1638,8 +1638,10 @@ vect_finish_stmt_generation (vec_info *vinfo,
 	      && ((is_gimple_assign (vec_stmt)
 		   && !is_gimple_reg (gimple_assign_lhs (vec_stmt)))
 		  || (is_gimple_call (vec_stmt)
-		      && !(gimple_call_flags (vec_stmt)
-			   & (ECF_CONST|ECF_PURE|ECF_NOVOPS)))))
+		      && (!(gimple_call_flags (vec_stmt)
+			    & (ECF_CONST|ECF_PURE|ECF_NOVOPS))
+			  || (gimple_call_lhs (vec_stmt)
+			      && !is_gimple_reg (gimple_call_lhs (vec_stmt)))))))
 	    {
 	      tree new_vdef = copy_ssa_name (vuse, vec_stmt);
 	      gimple_set_vdef (vec_stmt, new_vdef);


                 reply	other threads:[~2022-07-05 10:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220705105559.608843856DD4@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).