public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc/devel/rust/master] ast: Fix use after move in GenericArg
Date: Fri,  8 Jul 2022 07:31:03 +0000 (GMT)	[thread overview]
Message-ID: <20220708073103.3A9103856DD2@sourceware.org> (raw)

https://gcc.gnu.org/g:465c59f26041683f07a817e1f8fdda7a8269e5a3

commit 465c59f26041683f07a817e1f8fdda7a8269e5a3
Author: Arthur Cohen <arthur.cohen@embecosm.com>
Date:   Thu Jul 7 13:28:43 2022 +0200

    ast: Fix use after move in GenericArg

Diff:
---
 gcc/rust/ast/rust-path.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gcc/rust/ast/rust-path.h b/gcc/rust/ast/rust-path.h
index 722ed93ec57..cc79e278f05 100644
--- a/gcc/rust/ast/rust-path.h
+++ b/gcc/rust/ast/rust-path.h
@@ -164,14 +164,14 @@ public:
 
   static GenericArg create_const (std::unique_ptr<Expr> expression)
   {
-    return GenericArg (std::move (expression), nullptr, "", Kind::Const,
-		       expression->get_locus ());
+    auto locus = expression->get_locus ();
+    return GenericArg (std::move (expression), nullptr, "", Kind::Const, locus);
   }
 
   static GenericArg create_type (std::unique_ptr<Type> type)
   {
-    return GenericArg (nullptr, std::move (type), "", Kind::Type,
-		       type->get_locus ());
+    auto locus = type->get_locus ();
+    return GenericArg (nullptr, std::move (type), "", Kind::Type, locus);
   }
 
   static GenericArg create_ambiguous (Identifier path, Location locus)


                 reply	other threads:[~2022-07-08  7:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220708073103.3A9103856DD2@sourceware.org \
    --to=tschwinge@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).