public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jeff Law <law@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-1582] [PATCH][s390]: Fix the usage of store_bit_field in the backend.
Date: Sat,  9 Jul 2022 01:56:42 +0000 (GMT)	[thread overview]
Message-ID: <20220709015642.A167F3858406@sourceware.org> (raw)

https://gcc.gnu.org/g:84ff566c63cde517c7d963a554e338531fb059f1

commit r13-1582-g84ff566c63cde517c7d963a554e338531fb059f1
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Fri Jul 8 21:54:44 2022 -0400

    [PATCH][s390]: Fix the usage of store_bit_field in the backend.
    
    Hi All,
    
    I seem to have broken the s390 bootstrap because I added a new parameter to the
    store_bit_field function to indicate whether the value the field of is being set
    is currently undefined.
    
    If it's undefined we use a subreg instead.  In this case the value of false
    restores the old behavior.
    
    Ok for master?
    
    Thanks,
    Tamar
    
    gcc/ChangeLog:
    
            * config/s390/s390.cc (s390_expand_atomic): Pass false to store_bit_field to
            indicate that the value is not undefined.

Diff:
---
 gcc/config/s390/s390.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/s390/s390.cc b/gcc/config/s390/s390.cc
index 444b1ec20d7..5aaf76a9490 100644
--- a/gcc/config/s390/s390.cc
+++ b/gcc/config/s390/s390.cc
@@ -7468,7 +7468,7 @@ s390_expand_atomic (machine_mode mode, enum rtx_code code,
     case SET:
       if (ac.aligned && MEM_P (val))
 	store_bit_field (new_rtx, GET_MODE_BITSIZE (mode), 0,
-			 0, 0, SImode, val, false);
+			 0, 0, SImode, val, false, false);
       else
 	{
 	  new_rtx = expand_simple_binop (SImode, AND, new_rtx, ac.modemaski,


                 reply	other threads:[~2022-07-09  1:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220709015642.A167F3858406@sourceware.org \
    --to=law@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).