public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1653] tree-optimization/106249 - unroll-and-jam and LC SSA upate Date: Wed, 13 Jul 2022 07:36:07 +0000 (GMT) [thread overview] Message-ID: <20220713073607.A5E82385357D@sourceware.org> (raw) https://gcc.gnu.org/g:c479c40f8c8fee0fb70e8a365b61c55739f448e1 commit r13-1653-gc479c40f8c8fee0fb70e8a365b61c55739f448e1 Author: Richard Biener <rguenther@suse.de> Date: Wed Jul 13 08:27:57 2022 +0200 tree-optimization/106249 - unroll-and-jam and LC SSA upate When I delayed the LC SSA update in unroll-and-jam this exposed an issue that tree_transform_and_unroll_loop does a full function LC SSA verification when new_loop is NULL (when it doesn't need to do versioning). That wasn't intended. I also took the chance to make the versioning in tree_transform_and_unroll_loop use TODO_update_ssa_nophi for the loop versioning SSA update which I somehow missed earlier. PR tree-optimization/106249 * tree-ssa-loop-manip.cc (tree_transform_and_unroll_loop): Only verify LC SSA of the new_loop if we created it. Use TODO_update_ssa_nophi for the SSA update after versioning the loop. * gcc.dg/pr106249.c: New testcase. Diff: --- gcc/testsuite/gcc.dg/pr106249.c | 16 ++++++++++++++++ gcc/tree-ssa-loop-manip.cc | 5 +++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.dg/pr106249.c b/gcc/testsuite/gcc.dg/pr106249.c new file mode 100644 index 00000000000..f97b07fb4da --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr106249.c @@ -0,0 +1,16 @@ +/* { dg-do compile } */ +/* { dg-options "-O -floop-unroll-and-jam --param unroll-jam-min-percent=0" } */ + +void +foo (double *arr) +{ + int i, j; + + for (i = 0; i < 4; ++i) + for (j = 0; j < 4; ++j) + arr[j] = 0; + + for (i = 1; i < 4; ++i) + for (j = 0; j < 4; ++j) + arr[j] = 1.0 / (i + 1); +} diff --git a/gcc/tree-ssa-loop-manip.cc b/gcc/tree-ssa-loop-manip.cc index c531f1f12fd..410a8516370 100644 --- a/gcc/tree-ssa-loop-manip.cc +++ b/gcc/tree-ssa-loop-manip.cc @@ -1208,7 +1208,7 @@ tree_transform_and_unroll_loop (class loop *loop, unsigned factor, profile_probability::guessed_always (), true); gcc_assert (new_loop != NULL); - update_ssa (TODO_update_ssa); + update_ssa (TODO_update_ssa_no_phi); /* Prepare the cfg and update the phi nodes. Move the loop exit to the loop latch (and make its condition dummy, for the moment). */ @@ -1428,7 +1428,8 @@ tree_transform_and_unroll_loop (class loop *loop, unsigned factor, checking_verify_flow_info (); checking_verify_loop_structure (); checking_verify_loop_closed_ssa (true, loop); - checking_verify_loop_closed_ssa (true, new_loop); + if (new_loop) + checking_verify_loop_closed_ssa (true, new_loop); } /* Wrapper over tree_transform_and_unroll_loop for case we do not
reply other threads:[~2022-07-13 7:36 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220713073607.A5E82385357D@sourceware.org \ --to=rguenth@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).