From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id 67D5A385357E; Wed, 13 Jul 2022 14:26:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 67D5A385357E MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1684] Clear nonzero mask when inverting ranges. X-Act-Checkin: gcc X-Git-Author: Aldy Hernandez X-Git-Refname: refs/heads/master X-Git-Oldrev: c7970b146f98f58a803a37e9a0b21bb97f1dadd8 X-Git-Newrev: 554b21edb9ec91a898125d4915d790c6d4b9a688 Message-Id: <20220713142611.67D5A385357E@sourceware.org> Date: Wed, 13 Jul 2022 14:26:11 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 14:26:11 -0000 https://gcc.gnu.org/g:554b21edb9ec91a898125d4915d790c6d4b9a688 commit r13-1684-g554b21edb9ec91a898125d4915d790c6d4b9a688 Author: Aldy Hernandez Date: Wed Jul 13 12:38:35 2022 +0200 Clear nonzero mask when inverting ranges. Every time we set a range we should take into account the nonzero mask. This happens automatically for the set() methods, plus all the other assignment, intersect, and union methods. Unfortunately I forgot about the invert code. Also, for good measure I audited the rest of the setters in value_range.cc and plugged the legacy code to pessimize the masks to -1 for union/intersect, since we don't support the masks on them (or rather, we don't keep very good track of them). Tested on x86-64 Linux. gcc/ChangeLog: * value-range.cc (irange::copy_to_legacy): Set nonzero mask. (irange::legacy_intersect): Clear nonzero mask. (irange::legacy_union): Same. (irange::invert): Same. Diff: --- gcc/value-range.cc | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index 2aa973b2af2..528ed547ef3 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -331,6 +331,7 @@ irange::copy_to_legacy (const irange &src) m_base[0] = src.m_base[0]; m_base[1] = src.m_base[1]; m_kind = src.m_kind; + m_nonzero_mask = src.m_nonzero_mask; return; } // Copy multi-range to legacy. @@ -1336,6 +1337,9 @@ irange::legacy_intersect (irange *vr0, const irange *vr1) intersect_ranges (&vr0kind, &vr0min, &vr0max, vr1->kind (), vr1->min (), vr1->max ()); + // Pessimize nonzero masks, as we don't support them. + m_nonzero_mask = NULL; + /* Make sure to canonicalize the result though as the inversion of a VR_RANGE can still be a VR_RANGE. */ if (vr0kind == VR_UNDEFINED) @@ -1657,6 +1661,9 @@ irange::legacy_union (irange *vr0, const irange *vr1) union_ranges (&vr0kind, &vr0min, &vr0max, vr1->kind (), vr1->min (), vr1->max ()); + // Pessimize nonzero masks, as we don't support them. + m_nonzero_mask = NULL; + if (vr0kind == VR_UNDEFINED) vr0->set_undefined (); else if (vr0kind == VR_VARYING) @@ -2253,6 +2260,7 @@ irange::invert () } gcc_checking_assert (!undefined_p () && !varying_p ()); + m_nonzero_mask = NULL; // We always need one more set of bounds to represent an inverse, so // if we're at the limit, we can't properly represent things.