public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Thomas Schwinge <tschwinge@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc/devel/rust/master] Merge #1391 Date: Mon, 18 Jul 2022 07:05:26 +0000 (GMT) [thread overview] Message-ID: <20220718070526.C3CFE3857C4D@sourceware.org> (raw) https://gcc.gnu.org/g:e4cdb24c468b8a848980f7138767fbe093471c5b commit e4cdb24c468b8a848980f7138767fbe093471c5b Merge: fd2bd659e44 9c7a580aa13 Author: bors[bot] <26634292+bors[bot]@users.noreply.github.com> Date: Sun Jul 17 19:52:16 2022 +0000 Merge #1391 1391: Fix ICE on duplicate compilation of ExternBlock items r=philberty a=philberty When we declare an extern block after where it is used the query compilation system in the backend code-gen pass will resolve this and compile as required. But when the iteration of the crate as part of the pipeline we end up compiling this function again. The check we used to stop this was copy paste from the other function items but in this case the check for function_completed is not valid as this is a prototype for an extern item so we dont add this to the translation unit as an fndecl which meant we hit the ICE where we compile and add it again. Fixes #1323 Co-authored-by: Philip Herron <philip.herron@embecosm.com> Diff: gcc/rust/backend/rust-compile-extern.h | 20 ++++++++++++-------- gcc/testsuite/rust/compile/issue-1323-1.rs | 18 ++++++++++++++++++ gcc/testsuite/rust/compile/issue-1323-2.rs | 16 ++++++++++++++++ 3 files changed, 46 insertions(+), 8 deletions(-)
reply other threads:[~2022-07-18 7:05 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220718070526.C3CFE3857C4D@sourceware.org \ --to=tschwinge@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).