public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1729] arc: Fix interrupt's epilogue.
@ 2022-07-18 11:37 Claudiu Zissulescu
  0 siblings, 0 replies; only message in thread
From: Claudiu Zissulescu @ 2022-07-18 11:37 UTC (permalink / raw)
  To: gcc-cvs

https://gcc.gnu.org/g:9c8349ee1a35dac61b84bbae115ee6a1eeb6ddbd

commit r13-1729-g9c8349ee1a35dac61b84bbae115ee6a1eeb6ddbd
Author: Claudiu Zissulescu <claziss@gmail.com>
Date:   Mon Jul 18 14:32:41 2022 +0300

    arc: Fix interrupt's epilogue.
    
    The stack pointer adjustment in interrupt epilogue is happening after
    restoring the ZOL registers which is wrong. Fixing this.
    
    gcc/
            * config/arc/arc.cc (arc_expand_epilogue): Adjust the frame
            pointer first when in interrupts.
    
    gcc/testsuite/
            * gcc.target/arc/interrupt-13.c: New file.
    
    Signed-off-by: Claudiu Zissulescu <claziss@gmail.com>

Diff:
---
 gcc/config/arc/arc.cc                       |  2 +-
 gcc/testsuite/gcc.target/arc/interrupt-13.c | 15 +++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/gcc/config/arc/arc.cc b/gcc/config/arc/arc.cc
index fbc17e684a0..77730c88e55 100644
--- a/gcc/config/arc/arc.cc
+++ b/gcc/config/arc/arc.cc
@@ -3965,7 +3965,7 @@ arc_expand_epilogue (int sibcall_p)
   if (size)
     emit_insn (gen_blockage ());
 
-  if (ARC_INTERRUPT_P (fn_type) && restore_fp)
+  if (ARC_INTERRUPT_P (fn_type))
     {
       /* We need to restore FP before any SP operation in an
 	 interrupt.  */
diff --git a/gcc/testsuite/gcc.target/arc/interrupt-13.c b/gcc/testsuite/gcc.target/arc/interrupt-13.c
new file mode 100644
index 00000000000..0ed8451c512
--- /dev/null
+++ b/gcc/testsuite/gcc.target/arc/interrupt-13.c
@@ -0,0 +1,15 @@
+/* { dg-options "-O2" } */
+
+extern int foo (int *);
+
+void __attribute__((interrupt("ilink")))
+irq (void)
+{
+  struct {
+    int x0;
+    int x1;
+  } a = {1 ,2};
+  foo ((int *)&a);
+}
+
+/* { dg-final { scan-assembler "add_s\\s+sp,sp,8.*pop_s\\s+r0" } } */


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-18 11:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 11:37 [gcc r13-1729] arc: Fix interrupt's epilogue Claudiu Zissulescu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).