From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1734) id 87E953858C52; Tue, 19 Jul 2022 18:25:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 87E953858C52 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Marek Polacek To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-8585] c++: fix SIGFPE with -Wclass-memaccess [PR105634] X-Act-Checkin: gcc X-Git-Author: Marek Polacek X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: 1a7200da71550e6f92da66f0b328bb20d3bcdf35 X-Git-Newrev: deafa40eb57b39626e116ca6a15d34a34c57c9f6 Message-Id: <20220719182546.87E953858C52@sourceware.org> Date: Tue, 19 Jul 2022 18:25:46 +0000 (GMT) X-BeenThere: gcc-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 18:25:46 -0000 https://gcc.gnu.org/g:deafa40eb57b39626e116ca6a15d34a34c57c9f6 commit r12-8585-gdeafa40eb57b39626e116ca6a15d34a34c57c9f6 Author: Marek Polacek Date: Tue Jul 19 14:24:25 2022 -0400 c++: fix SIGFPE with -Wclass-memaccess [PR105634] Here we crash because we attempt to % by 0. Thus fixed. PR c++/105634 gcc/cp/ChangeLog: * call.cc (maybe_warn_class_memaccess): Avoid % by zero. gcc/testsuite/ChangeLog: * g++.dg/warn/Wclass-memaccess-7.C: New test. Diff: --- gcc/cp/call.cc | 2 ++ gcc/testsuite/g++.dg/warn/Wclass-memaccess-7.C | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc index 726770d4db8..af92a961000 100644 --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -10333,6 +10333,8 @@ maybe_warn_class_memaccess (location_t loc, tree fndecl, /* Finally, warn on partial copies. */ unsigned HOST_WIDE_INT typesize = tree_to_uhwi (TYPE_SIZE_UNIT (desttype)); + if (typesize == 0) + break; if (unsigned HOST_WIDE_INT partial = tree_to_uhwi (sz) % typesize) warned = warning_at (loc, OPT_Wclass_memaccess, (typesize - partial > 1 diff --git a/gcc/testsuite/g++.dg/warn/Wclass-memaccess-7.C b/gcc/testsuite/g++.dg/warn/Wclass-memaccess-7.C new file mode 100644 index 00000000000..7e86b248629 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wclass-memaccess-7.C @@ -0,0 +1,13 @@ +// PR c++/105634 +// { dg-do compile { target { c++11 } } } +// { dg-options "-Wall" } + +struct s +{ + struct {} a[] = 1.0; // { dg-error "" } + void f (char *c) + { + s s; + __builtin_memcpy (&s, c, sizeof(s)); + } +};