public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Surya Kumari Jangala <jskumari@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-10156] regrename: Fix -fcompare-debug issue in check_new_reg_p [PR105041] Date: Thu, 21 Jul 2022 06:38:15 +0000 (GMT) [thread overview] Message-ID: <20220721063815.194B43858D28@sourceware.org> (raw) https://gcc.gnu.org/g:8522fab3f900d6fe0cc43be52fdd850f5c9c44db commit r11-10156-g8522fab3f900d6fe0cc43be52fdd850f5c9c44db Author: Surya Kumari Jangala <jskumari@linux.vnet.ibm.com> Date: Fri Jun 10 19:52:57 2022 +0530 regrename: Fix -fcompare-debug issue in check_new_reg_p [PR105041] In check_new_reg_p, the nregs of a du chain is computed by obtaining the MODE of the first element in the chain, and then calling hard_regno_nregs() with the MODE. But the first element of the chain can be a DEBUG_INSN whose mode need not be the same as the rest of the elements in the du chain. This was resulting in fcompare-debug failure as check_new_reg_p was returning a different result with -g for the same candidate register. We can instead obtain nregs from the du chain itself. 2022-06-10 Surya Kumari Jangala <jskumari@linux.ibm.com> gcc/ PR rtl-optimization/105041 * regrename.c (check_new_reg_p): Use nregs value from du chain. gcc/testsuite/ PR rtl-optimization/105041 * gcc.target/powerpc/pr105041.c: New test. (cherry picked from commit 3e16b4359e86b36676ed01219e6deafa95f3c16b) Diff: --- gcc/regrename.c | 3 +-- gcc/testsuite/gcc.target/powerpc/pr105041.c | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/gcc/regrename.c b/gcc/regrename.c index c0d4643f802..0cf93d323d9 100644 --- a/gcc/regrename.c +++ b/gcc/regrename.c @@ -324,8 +324,7 @@ static bool check_new_reg_p (int reg ATTRIBUTE_UNUSED, int new_reg, class du_head *this_head, HARD_REG_SET this_unavailable) { - machine_mode mode = GET_MODE (*this_head->first->loc); - int nregs = hard_regno_nregs (new_reg, mode); + int nregs = this_head->nregs; int i; struct du_chain *tmp; diff --git a/gcc/testsuite/gcc.target/powerpc/pr105041.c b/gcc/testsuite/gcc.target/powerpc/pr105041.c new file mode 100644 index 00000000000..c52b7a5ef30 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr105041.c @@ -0,0 +1,22 @@ +/* { dg-options "-mdejagnu-cpu=power4 -O2 -fcompare-debug -frename-registers" } */ + +double m; +int n; + +unsigned int +foo (unsigned int x, int y) +{ + long long int a = y, b = !a; + int c = 0; + + if (b != x) + while ((int) m == a) + { + c = a; + a = 0; + } + + n = b = y; + + return x + c; +}
reply other threads:[~2022-07-21 6:38 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220721063815.194B43858D28@sourceware.org \ --to=jskumari@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).