public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jason Merrill <jason@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r11-10160] c++: defaulted friend op== [PR106361]
Date: Fri, 22 Jul 2022 05:40:58 +0000 (GMT)	[thread overview]
Message-ID: <20220722054058.7C9033835839@sourceware.org> (raw)

https://gcc.gnu.org/g:1503d946c06e2005c860f56231d2ea582a8a340f

commit r11-10160-g1503d946c06e2005c860f56231d2ea582a8a340f
Author: Jason Merrill <jason@redhat.com>
Date:   Wed Jul 20 20:00:58 2022 -0400

    c++: defaulted friend op== [PR106361]
    
    Now non-member functions can be defaulted, so this assert is wrong.
    move_signature_fn_p already checks for ctor or op=.
    
            PR c++/106361
    
    gcc/cp/ChangeLog:
    
            * decl.c (move_fn_p): Remove assert.
    
    gcc/testsuite/ChangeLog:
    
            * g++.dg/cpp2a/spaceship-eq14.C: New test.

Diff:
---
 gcc/cp/decl.c                               |  2 --
 gcc/testsuite/g++.dg/cpp2a/spaceship-eq14.C | 17 +++++++++++++++++
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index 052378a2e75..514d4c1bc20 100644
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -14689,8 +14689,6 @@ copy_fn_p (const_tree d)
 bool
 move_fn_p (const_tree d)
 {
-  gcc_assert (DECL_FUNCTION_MEMBER_P (d));
-
   if (cxx_dialect == cxx98)
     /* There are no move constructors if we are in C++98 mode.  */
     return false;
diff --git a/gcc/testsuite/g++.dg/cpp2a/spaceship-eq14.C b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq14.C
new file mode 100644
index 00000000000..896e5232bf6
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp2a/spaceship-eq14.C
@@ -0,0 +1,17 @@
+// PR c++/106361
+// { dg-do compile { target c++20 } }
+
+struct foo {
+  int x;
+};
+
+struct bar {
+  foo f;			// { dg-error "operator==" }
+  friend bool operator==(const bar& a, const bar& b);
+};
+
+bool operator==(const bar& a, const bar& b) = default;
+
+int main() {
+  return bar{} == bar{};	// { dg-error "deleted" }
+}


                 reply	other threads:[~2022-07-22  5:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220722054058.7C9033835839@sourceware.org \
    --to=jason@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).