public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-1926] tree-optimization/106498 - reduce SSA updates in autopar
Date: Tue,  2 Aug 2022 06:40:45 +0000 (GMT)	[thread overview]
Message-ID: <20220802064045.CF13B3853833@sourceware.org> (raw)

https://gcc.gnu.org/g:c30bbd4d169c98b7535a30384c6a971ee875fa44

commit r13-1926-gc30bbd4d169c98b7535a30384c6a971ee875fa44
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Aug 2 08:37:16 2022 +0200

    tree-optimization/106498 - reduce SSA updates in autopar
    
    The following reduces the number of SSA updates done during autopar
    OMP expansion, specifically avoiding the cases that just add virtual
    operands (where maybe none have been before) in dead regions of the CFG.
    
    Instead virtual SSA update is delayed until after the pass.  There's
    much more TLC needed here, but test coverage makes it really difficult.
    
            PR tree-optimization/106498
            * omp-expand.cc (expand_omp_taskreg): Do not perform virtual
            SSA update here.
            (expand_omp_for): Or here.
            (execute_expand_omp): Instead schedule it here together
            with CFG cleanup via TODO.

Diff:
---
 gcc/omp-expand.cc | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/gcc/omp-expand.cc b/gcc/omp-expand.cc
index 936adff7f45..64e6308fc7b 100644
--- a/gcc/omp-expand.cc
+++ b/gcc/omp-expand.cc
@@ -1530,8 +1530,6 @@ expand_omp_taskreg (struct omp_region *region)
     expand_teams_call (new_bb, as_a <gomp_teams *> (entry_stmt));
   else
     expand_task_call (region, new_bb, as_a <gomp_task *> (entry_stmt));
-  if (gimple_in_ssa_p (cfun))
-    update_ssa (TODO_update_ssa_only_virtuals);
 }
 
 /* Information about members of an OpenACC collapsed loop nest.  */
@@ -8191,9 +8189,6 @@ expand_omp_for (struct omp_region *region, gimple *inner_stmt)
 			      (enum built_in_function) next_ix, sched_arg,
 			      inner_stmt);
     }
-
-  if (gimple_in_ssa_p (cfun))
-    update_ssa (TODO_update_ssa_only_virtuals);
 }
 
 /* Expand code for an OpenMP sections directive.  In pseudo code, we generate
@@ -10591,13 +10586,10 @@ execute_expand_omp (void)
 
   expand_omp (root_omp_region);
 
-  if (flag_checking && !loops_state_satisfies_p (LOOPS_NEED_FIXUP))
-    verify_loop_structure ();
-  cleanup_tree_cfg ();
-
   omp_free_regions ();
 
-  return 0;
+  return (TODO_cleanup_cfg
+	  | (gimple_in_ssa_p (cfun) ? TODO_update_ssa_only_virtuals : 0));
 }
 
 /* OMP expansion -- the default pass, run before creation of SSA form.  */


                 reply	other threads:[~2022-08-02  6:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802064045.CF13B3853833@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).