public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Biener <rguenth@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-1929] tree-optimization/106497 - more forward threader can-copy-bb
Date: Tue,  2 Aug 2022 11:29:49 +0000 (GMT)	[thread overview]
Message-ID: <20220802112949.AA54D3853828@sourceware.org> (raw)

https://gcc.gnu.org/g:0f3514756e0b4d8993ee43dcd958974eb1424061

commit r13-1929-g0f3514756e0b4d8993ee43dcd958974eb1424061
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Aug 2 12:19:25 2022 +0200

    tree-optimization/106497 - more forward threader can-copy-bb
    
    This adds EDGE_COPY_SRC_JOINER_BLOCK sources to the set of blocks
    we need to check we can duplicate.
    
            PR tree-optimization/106497
            * tree-ssa-threadupdate.cc (fwd_jt_path_registry::update_cfg):
            Also verify we can copy EDGE_COPY_SRC_JOINER_BLOCK.
    
            * gcc.dg/torture/pr106497.c: New testcase.

Diff:
---
 gcc/testsuite/gcc.dg/torture/pr106497.c | 20 ++++++++++++++++++++
 gcc/tree-ssa-threadupdate.cc            |  3 ++-
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.dg/torture/pr106497.c b/gcc/testsuite/gcc.dg/torture/pr106497.c
new file mode 100644
index 00000000000..601200de9e3
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/torture/pr106497.c
@@ -0,0 +1,20 @@
+/* { dg-do compile } */
+/* { dg-additional-options "-fno-tree-dce" } */
+
+int n;
+
+__attribute__ ((pure,returns_twice)) int
+bar (void);
+
+int
+foo (int x)
+{
+  n = 0;
+
+  bar ();
+
+  if (x && n)
+    return 0;
+
+  foo (x);
+}
diff --git a/gcc/tree-ssa-threadupdate.cc b/gcc/tree-ssa-threadupdate.cc
index 0f2b319d44a..59c268a3567 100644
--- a/gcc/tree-ssa-threadupdate.cc
+++ b/gcc/tree-ssa-threadupdate.cc
@@ -2679,7 +2679,8 @@ fwd_jt_path_registry::update_cfg (bool may_peel_loop_headers)
 	  {
 	    edge e = (*path)[j]->e;
 	    if (m_removed_edges->find_slot (e, NO_INSERT)
-		|| ((*path)[j]->type == EDGE_COPY_SRC_BLOCK
+		|| (((*path)[j]->type == EDGE_COPY_SRC_BLOCK
+		     || (*path)[j]->type == EDGE_COPY_SRC_JOINER_BLOCK)
 		    && !can_duplicate_block_p (e->src)))
 	      break;
 	  }


                 reply	other threads:[~2022-08-02 11:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802112949.AA54D3853828@sourceware.org \
    --to=rguenth@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).