public inbox for gcc-cvs@sourceware.org help / color / mirror / Atom feed
From: Andrew Macleod <amacleod@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-1965] Loop over intersected bitmaps. Date: Thu, 4 Aug 2022 18:29:00 +0000 (GMT) [thread overview] Message-ID: <20220804182900.DE50E3857B9A@sourceware.org> (raw) https://gcc.gnu.org/g:8e34d92ef29a175b84cc7f5185db43656ae762bb commit r13-1965-g8e34d92ef29a175b84cc7f5185db43656ae762bb Author: Andrew MacLeod <amacleod@redhat.com> Date: Thu Aug 4 12:22:59 2022 -0400 Loop over intersected bitmaps. compute_ranges_in_block loops over the import list and then checks the same bit in exports. It is nmore efficent to loop over the intersection of the 2 bitmaps. PR tree-optimization/106514 * gimple-range-path.cc (path_range_query::compute_ranges_in_block): Use EXECUTE_IF_AND_IN_BITMAP to loop over 2 bitmaps. Diff: --- gcc/gimple-range-path.cc | 40 ++++++++++++++++++---------------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/gcc/gimple-range-path.cc b/gcc/gimple-range-path.cc index e1b9683c1e4..43e7526b6fc 100644 --- a/gcc/gimple-range-path.cc +++ b/gcc/gimple-range-path.cc @@ -479,32 +479,28 @@ path_range_query::compute_ranges_in_block (basic_block bb) p->set_root_oracle (nullptr); } - EXECUTE_IF_SET_IN_BITMAP (m_imports, 0, i, bi) + gori_compute &g = m_ranger->gori (); + bitmap exports = g.exports (bb); + EXECUTE_IF_AND_IN_BITMAP (m_imports, exports, 0, i, bi) { tree name = ssa_name (i); - gori_compute &g = m_ranger->gori (); - bitmap exports = g.exports (bb); - - if (bitmap_bit_p (exports, i)) + Value_Range r (TREE_TYPE (name)); + if (g.outgoing_edge_range_p (r, e, name, *this)) { - Value_Range r (TREE_TYPE (name)); - if (g.outgoing_edge_range_p (r, e, name, *this)) + Value_Range cached_range (TREE_TYPE (name)); + if (get_cache (cached_range, name)) + r.intersect (cached_range); + + set_cache (r, name); + if (DEBUG_SOLVER) { - Value_Range cached_range (TREE_TYPE (name)); - if (get_cache (cached_range, name)) - r.intersect (cached_range); - - set_cache (r, name); - if (DEBUG_SOLVER) - { - fprintf (dump_file, "outgoing_edge_range_p for "); - print_generic_expr (dump_file, name, TDF_SLIM); - fprintf (dump_file, " on edge %d->%d ", - e->src->index, e->dest->index); - fprintf (dump_file, "is "); - r.dump (dump_file); - fprintf (dump_file, "\n"); - } + fprintf (dump_file, "outgoing_edge_range_p for "); + print_generic_expr (dump_file, name, TDF_SLIM); + fprintf (dump_file, " on edge %d->%d ", + e->src->index, e->dest->index); + fprintf (dump_file, "is "); + r.dump (dump_file); + fprintf (dump_file, "\n"); } } }
reply other threads:[~2022-08-04 18:29 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220804182900.DE50E3857B9A@sourceware.org \ --to=amacleod@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).