From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1464) id 58724385828A; Sun, 28 Aug 2022 00:44:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 58724385828A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661647496; bh=97eNnAB8OENEmroYUGasA1vAO1oyZvzLDIBfAJhFuLs=; h=From:To:Subject:Date:From; b=cPEF+I/crdOMX3KyLq9sJkQ8Grms2wsBZx8eLi80wTO5WIY3E5VyPpDZ2b5Kmuj99 Sfwz539C3cbP3I3lqWrJsCw0rz7mTLRpx6WqEohjlJsvMjdRqKVIrlgGqbBMu4+AP0 VPgdV7UBe4ZApPZmD2+wZ3ZZHibmfrk5UEJexGo0= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Peter Bergner To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2239] rs6000: Allow conversions of MMA pointer types [PR106017] X-Act-Checkin: gcc X-Git-Author: Peter Bergner X-Git-Refname: refs/heads/master X-Git-Oldrev: 6b226ef735f05264cdb51e3bc754d1b178108e3f X-Git-Newrev: 1ae1325f24cea1698b56e4299d95446a1f7b90a2 Message-Id: <20220828004456.58724385828A@sourceware.org> Date: Sun, 28 Aug 2022 00:44:56 +0000 (GMT) List-Id: https://gcc.gnu.org/g:1ae1325f24cea1698b56e4299d95446a1f7b90a2 commit r13-2239-g1ae1325f24cea1698b56e4299d95446a1f7b90a2 Author: Peter Bergner Date: Sat Aug 27 19:44:16 2022 -0500 rs6000: Allow conversions of MMA pointer types [PR106017] GCC incorrectly disables conversions between MMA pointer types, which are allowed with clang. The original intent was to disable conversions between MMA types and other other types, but pointer conversions should have been allowed. The fix is to just remove the MMA pointer conversion handling code altogether. gcc/ PR target/106017 * config/rs6000/rs6000.cc (rs6000_invalid_conversion): Remove handling of MMA pointer conversions. gcc/testsuite/ PR target/106017 * gcc.target/powerpc/pr106017.c: New test. Diff: --- gcc/config/rs6000/rs6000.cc | 22 ---------------------- gcc/testsuite/gcc.target/powerpc/pr106017.c | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc index df491bee2ea..2f3146e56f8 100644 --- a/gcc/config/rs6000/rs6000.cc +++ b/gcc/config/rs6000/rs6000.cc @@ -28188,28 +28188,6 @@ rs6000_invalid_conversion (const_tree fromtype, const_tree totype) if (tomode == OOmode) return N_("invalid conversion to type %<__vector_pair%>"); } - else if (POINTER_TYPE_P (fromtype) && POINTER_TYPE_P (totype)) - { - /* We really care about the modes of the base types. */ - frommode = TYPE_MODE (TREE_TYPE (fromtype)); - tomode = TYPE_MODE (TREE_TYPE (totype)); - - /* Do not allow conversions to/from XOmode and OOmode pointer - types, except to/from void pointers. */ - if (frommode != tomode - && frommode != VOIDmode - && tomode != VOIDmode) - { - if (frommode == XOmode) - return N_("invalid conversion from type %<__vector_quad *%>"); - if (tomode == XOmode) - return N_("invalid conversion to type %<__vector_quad *%>"); - if (frommode == OOmode) - return N_("invalid conversion from type %<__vector_pair *%>"); - if (tomode == OOmode) - return N_("invalid conversion to type %<__vector_pair *%>"); - } - } /* Conversion allowed. */ return NULL; diff --git a/gcc/testsuite/gcc.target/powerpc/pr106017.c b/gcc/testsuite/gcc.target/powerpc/pr106017.c new file mode 100644 index 00000000000..46d6c7a4a33 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr106017.c @@ -0,0 +1,19 @@ +/* PR target/106017 */ +/* { dg-options "-O1 -mdejagnu-cpu=power10" } */ +/* { dg-require-effective-target power10_ok } */ + +/* Make sure we do not flag any errors on the following test cases. */ + +void takeacc(__vector_quad *); +void +foo (void) +{ + __vector_quad arr[4]; + takeacc (arr); +} + +unsigned char * +bar (__vector_quad *a) +{ + return (unsigned char *)a; +}