From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1464) id 023CF396E871; Tue, 30 Aug 2022 00:22:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 023CF396E871 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661818921; bh=cikOs74KaJr3pACqtV6rXz7YO9qMJP6iCKHFMGdY6Gs=; h=From:To:Subject:Date:From; b=Z5WRzk/CHTvI9SKZh7z82xEIaQDFd3XvbkHZfi7WVALxLl/IjyCaCL4VDS2mL2RaJ doC2A3C5ytUtMXisvS1qdCqVlLeJSSAoaS2qbfzCzKXt8ALF3FwwsawRICBrwf+a0v hR2BMPUZFGHiCJKla9m2tJ6svOc73VSi05pqC+hk= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Peter Bergner To: gcc-cvs@gcc.gnu.org Subject: [gcc r11-10227] rs6000: Allow conversions of MMA pointer types [PR106017] X-Act-Checkin: gcc X-Git-Author: Peter Bergner X-Git-Refname: refs/heads/releases/gcc-11 X-Git-Oldrev: b40cfd9095be63c72522b6c06a8db5b7c10660d0 X-Git-Newrev: f494a85f0bf653c3128b376c1abf821a27748c11 Message-Id: <20220830002201.023CF396E871@sourceware.org> Date: Tue, 30 Aug 2022 00:22:00 +0000 (GMT) List-Id: https://gcc.gnu.org/g:f494a85f0bf653c3128b376c1abf821a27748c11 commit r11-10227-gf494a85f0bf653c3128b376c1abf821a27748c11 Author: Peter Bergner Date: Sat Aug 27 19:44:16 2022 -0500 rs6000: Allow conversions of MMA pointer types [PR106017] GCC incorrectly disables conversions between MMA pointer types, which are allowed with clang. The original intent was to disable conversions between MMA types and other other types, but pointer conversions should have been allowed. The fix is to just remove the MMA pointer conversion handling code altogether. gcc/ PR target/106017 * config/rs6000/rs6000.c (rs6000_invalid_conversion): Remove handling of MMA pointer conversions. gcc/testsuite/ PR target/106017 * gcc.target/powerpc/pr106017.c: New test. (cherry picked from commit 1ae1325f24cea1698b56e4299d95446a1f7b90a2) Diff: --- gcc/config/rs6000/rs6000.c | 22 ---------------------- gcc/testsuite/gcc.target/powerpc/pr106017.c | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index a4405d7facd..4352e8fd259 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -28032,28 +28032,6 @@ rs6000_invalid_conversion (const_tree fromtype, const_tree totype) if (tomode == OOmode) return N_("invalid conversion to type %<__vector_pair%>"); } - else if (POINTER_TYPE_P (fromtype) && POINTER_TYPE_P (totype)) - { - /* We really care about the modes of the base types. */ - frommode = TYPE_MODE (TREE_TYPE (fromtype)); - tomode = TYPE_MODE (TREE_TYPE (totype)); - - /* Do not allow conversions to/from XOmode and OOmode pointer - types, except to/from void pointers. */ - if (frommode != tomode - && frommode != VOIDmode - && tomode != VOIDmode) - { - if (frommode == XOmode) - return N_("invalid conversion from type %<* __vector_quad%>"); - if (tomode == XOmode) - return N_("invalid conversion to type %<* __vector_quad%>"); - if (frommode == OOmode) - return N_("invalid conversion from type %<* __vector_pair%>"); - if (tomode == OOmode) - return N_("invalid conversion to type %<* __vector_pair%>"); - } - } /* Conversion allowed. */ return NULL; diff --git a/gcc/testsuite/gcc.target/powerpc/pr106017.c b/gcc/testsuite/gcc.target/powerpc/pr106017.c new file mode 100644 index 00000000000..46d6c7a4a33 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr106017.c @@ -0,0 +1,19 @@ +/* PR target/106017 */ +/* { dg-options "-O1 -mdejagnu-cpu=power10" } */ +/* { dg-require-effective-target power10_ok } */ + +/* Make sure we do not flag any errors on the following test cases. */ + +void takeacc(__vector_quad *); +void +foo (void) +{ + __vector_quad arr[4]; + takeacc (arr); +} + +unsigned char * +bar (__vector_quad *a) +{ + return (unsigned char *)a; +}