From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1464) id 2592038358A4; Tue, 30 Aug 2022 01:13:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2592038358A4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661821985; bh=JxmmA4XtxTFV3GQ9O+AB4Som0LOdH3c33D5NqnaH+jY=; h=From:To:Subject:Date:From; b=h3R1WgNvIHbHRLmOsynGhFbTvgHnUarx0futgwmixRGuXt4aL3l9X8JJm1ONDRHNt L6091zDNezPiVqzlwOC10jqhL8Ge++UMPwn/XHDsVJIaJaM2WJUMFADB8i6cmRMhl1 MyZhHcaVk1zq/cfVhcI8FkrZa1OrnxyDiCrAITNU= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Peter Bergner To: gcc-cvs@gcc.gnu.org Subject: [gcc r10-10966] rs6000: Allow conversions of MMA pointer types [PR106017] X-Act-Checkin: gcc X-Git-Author: Peter Bergner X-Git-Refname: refs/heads/releases/gcc-10 X-Git-Oldrev: b541e149ab653e54545df6eda4154bfb16d4409c X-Git-Newrev: 3927bd9f9150576f2905c8930732c419f1850fca Message-Id: <20220830011305.2592038358A4@sourceware.org> Date: Tue, 30 Aug 2022 01:13:05 +0000 (GMT) List-Id: https://gcc.gnu.org/g:3927bd9f9150576f2905c8930732c419f1850fca commit r10-10966-g3927bd9f9150576f2905c8930732c419f1850fca Author: Peter Bergner Date: Sat Aug 27 19:44:16 2022 -0500 rs6000: Allow conversions of MMA pointer types [PR106017] GCC incorrectly disables conversions between MMA pointer types, which are allowed with clang. The original intent was to disable conversions between MMA types and other other types, but pointer conversions should have been allowed. The fix is to just remove the MMA pointer conversion handling code altogether. gcc/ PR target/106017 * config/rs6000/rs6000.c (rs6000_invalid_conversion): Remove handling of MMA pointer conversions. gcc/testsuite/ PR target/106017 * gcc.target/powerpc/pr106017.c: New test. (cherry picked from commit 1ae1325f24cea1698b56e4299d95446a1f7b90a2) Diff: --- gcc/config/rs6000/rs6000.c | 22 ---------------------- gcc/testsuite/gcc.target/powerpc/pr106017.c | 19 +++++++++++++++++++ 2 files changed, 19 insertions(+), 22 deletions(-) diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index 24696edfb8c..d6be8b7fb6b 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -26888,28 +26888,6 @@ rs6000_invalid_conversion (const_tree fromtype, const_tree totype) if (tomode == POImode) return N_("invalid conversion to type %<__vector_pair%>"); } - else if (POINTER_TYPE_P (fromtype) && POINTER_TYPE_P (totype)) - { - /* We really care about the modes of the base types. */ - frommode = TYPE_MODE (TREE_TYPE (fromtype)); - tomode = TYPE_MODE (TREE_TYPE (totype)); - - /* Do not allow conversions to/from PXImode and POImode pointer - types, except to/from void pointers. */ - if (frommode != tomode - && frommode != VOIDmode - && tomode != VOIDmode) - { - if (frommode == PXImode) - return N_("invalid conversion from type %<* __vector_quad%>"); - if (tomode == PXImode) - return N_("invalid conversion to type %<* __vector_quad%>"); - if (frommode == POImode) - return N_("invalid conversion from type %<* __vector_pair%>"); - if (tomode == POImode) - return N_("invalid conversion to type %<* __vector_pair%>"); - } - } /* Conversion allowed. */ return NULL; diff --git a/gcc/testsuite/gcc.target/powerpc/pr106017.c b/gcc/testsuite/gcc.target/powerpc/pr106017.c new file mode 100644 index 00000000000..46d6c7a4a33 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr106017.c @@ -0,0 +1,19 @@ +/* PR target/106017 */ +/* { dg-options "-O1 -mdejagnu-cpu=power10" } */ +/* { dg-require-effective-target power10_ok } */ + +/* Make sure we do not flag any errors on the following test cases. */ + +void takeacc(__vector_quad *); +void +foo (void) +{ + __vector_quad arr[4]; + takeacc (arr); +} + +unsigned char * +bar (__vector_quad *a) +{ + return (unsigned char *)a; +}