From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1666) id C889D385C413; Tue, 30 Aug 2022 11:15:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C889D385C413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1661858130; bh=FmaaO4IPIantOEIJUB/idRdWYmcL4vDQ6H2/E2joKgo=; h=From:To:Subject:Date:From; b=csqJ1IXSUcQ6b0dd3NKeHO6zJFnVjsT/xJgxgjQkhv2+Sl8bRvVdGOxnr0AWLI9o0 cDB80FTIEANlNtyVpBOcUlQFr+xiAmBs+LXf3pZLnBknbQ41Skh7VavyyraOPfPqVI qIda8c2x2QAIpfq6n9SUYp4ZPTlRgLJsQcHISdxE= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Richard Biener To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2273] tree-optimization/67196 - normalize use predicates earlier X-Act-Checkin: gcc X-Git-Author: Richard Biener X-Git-Refname: refs/heads/master X-Git-Oldrev: 70b2e511fe4a55a0c3fc7538c86c8851babd585f X-Git-Newrev: 61051ee5cfd59ee292984641d02caac85f6dfac3 Message-Id: <20220830111530.C889D385C413@sourceware.org> Date: Tue, 30 Aug 2022 11:15:30 +0000 (GMT) List-Id: https://gcc.gnu.org/g:61051ee5cfd59ee292984641d02caac85f6dfac3 commit r13-2273-g61051ee5cfd59ee292984641d02caac85f6dfac3 Author: Richard Biener Date: Tue Aug 30 11:47:49 2022 +0200 tree-optimization/67196 - normalize use predicates earlier The following makes sure to have use predicates simplified and normalized before doing uninit_analysis::overlap because that otherwise cannot pick up all flag setting cases. This fixes half of the issue in PR67196 and conveniently resolves the XFAIL in gcc.dg/uninit-pred-7_a.c. PR tree-optimization/67196 * gimple-predicate-analysis.cc (uninit_analysis::is_use_guarded): Simplify and normalize use prediates before first use. * gcc.dg/uninit-pred-7_a.c: Un-XFAIL. Diff: --- gcc/gimple-predicate-analysis.cc | 6 +++--- gcc/testsuite/gcc.dg/uninit-pred-7_a.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/gimple-predicate-analysis.cc b/gcc/gimple-predicate-analysis.cc index 2b279ccd4b6..f8c63d24537 100644 --- a/gcc/gimple-predicate-analysis.cc +++ b/gcc/gimple-predicate-analysis.cc @@ -2105,6 +2105,9 @@ uninit_analysis::is_use_guarded (gimple *use_stmt, basic_block use_bb, if (!init_use_preds (use_preds, def_bb, use_bb)) return false; + use_preds.simplify (use_stmt, /*is_use=*/true); + use_preds.normalize (use_stmt, /*is_use=*/true); + /* Try to prune the dead incoming phi edges. */ if (!overlap (phi, opnds, visited, use_preds)) { @@ -2124,9 +2127,6 @@ uninit_analysis::is_use_guarded (gimple *use_stmt, basic_block use_bb, m_phi_def_preds.normalize (phi); } - use_preds.simplify (use_stmt, /*is_use=*/true); - use_preds.normalize (use_stmt, /*is_use=*/true); - /* Return true if the predicate guarding the valid definition (i.e., *THIS) is a superset of the predicate guarding the use (i.e., USE_PREDS). */ diff --git a/gcc/testsuite/gcc.dg/uninit-pred-7_a.c b/gcc/testsuite/gcc.dg/uninit-pred-7_a.c index 434d90ac570..c2ba2a4248d 100644 --- a/gcc/testsuite/gcc.dg/uninit-pred-7_a.c +++ b/gcc/testsuite/gcc.dg/uninit-pred-7_a.c @@ -23,7 +23,7 @@ int foo (int n, int l, int m, int r) blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */ if ( l ) - blah(v); /* { dg-bogus "uninitialized" "bogus warning" { xfail *-*-* } } */ + blah(v); /* { dg-bogus "uninitialized" "bogus warning" } */ return 0; }