public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Filip Kastl <pheeck@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/pheeck/heads/sccp)] sccp now actually replaces phis with values
Date: Fri,  2 Sep 2022 15:31:42 +0000 (GMT)	[thread overview]
Message-ID: <20220902153142.B63313858406@sourceware.org> (raw)

https://gcc.gnu.org/g:c798727d40ceb10337f785c448d07e62c184513c

commit c798727d40ceb10337f785c448d07e62c184513c
Author: Filip Kastl <filip.kastl@gmail.com>
Date:   Fri Sep 2 17:31:36 2022 +0200

    sccp now actually replaces phis with values

Diff:
---
 gcc/sccp.cc | 36 +++++++++++++++++++++++++++++++++---
 1 file changed, 33 insertions(+), 3 deletions(-)

diff --git a/gcc/sccp.cc b/gcc/sccp.cc
index 8b57e3a4a3c..a4b332e0c29 100644
--- a/gcc/sccp.cc
+++ b/gcc/sccp.cc
@@ -320,14 +320,43 @@ replace_scc_by_value (vec<gphi *> scc, tree v)
 {
   for (gphi *phi : scc)
     {
-      // DEBUG
       tree ssa_name = gimple_get_lhs (phi);
+
+      // DEBUG
       unsigned vnum_get_replaced = SSA_NAME_VERSION (ssa_name);
       unsigned vnum_replaced_by = SSA_NAME_VERSION (v);
       std::cerr << "Replacing " << vnum_get_replaced << " by " <<
 	vnum_replaced_by << std::endl;
-      // TODO Remove phi statement and free ssa name
-      // TODO Replace occurences of phi with v
+
+      /* Replace each occurence of phi by value v.  */
+      use_operand_p use_p;
+      imm_use_iterator iter;
+      gimple *use_stmt;
+      FOR_EACH_IMM_USE_STMT (use_stmt, iter, ssa_name)
+	FOR_EACH_IMM_USE_ON_STMT (use_p, iter)
+	  SET_USE (use_p, v);
+    }
+}
+
+/* Remove all PHIs with zero uses.  */
+
+static void
+remove_zero_uses_phis ()
+{
+  basic_block bb;
+  FOR_EACH_BB_FN (bb, cfun)
+    {
+      gphi_iterator pi;
+      for (pi = gsi_start_phis (bb); !gsi_end_p (pi);)
+	{
+	  gphi *phi = pi.phi ();
+	  tree ssa_name = gimple_phi_result (phi);
+	  if (has_zero_uses (ssa_name))
+	    /* Note that remove_phi_node() also frees SSA name.  */
+	    remove_phi_node (&pi, true);
+	  else
+	    gsi_next (&pi);
+	}
     }
 }
 
@@ -393,6 +422,7 @@ remove_redundant_phis (vec<gphi *> phis)
     {
       process_scc (scc);
     }
+  remove_zero_uses_phis ();
 }
 
 /* TODO Pass description.  */

             reply	other threads:[~2022-09-02 15:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-02 15:31 Filip Kastl [this message]
2023-02-15 10:14 Filip Kastl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220902153142.B63313858406@sourceware.org \
    --to=pheeck@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).