From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id B032C3858D1E; Fri, 2 Sep 2022 19:12:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B032C3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1662145927; bh=K8NDI16HdBTX+QbD2gTp7TM+IVJCVWnqbyyVh5lz3oc=; h=From:To:Subject:Date:From; b=BsYbe2h8N/lf8CSD3hRwNzOZ6BM4ESk0/dydqjM6L11yYeAWPHUER8KWIQp8AbS0/ sZofun/zalxBfsgM+sRxnuQP+/hycXYB74A0FtG8dBKoan+sn7pNb53PV7zd4NuPQF U+PSKDsUc2EOV3stUsvmlzVpJ+EotEGYHctg2hpw= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2382] Fortran: avoid NULL pointer dereference on invalid DATA constant [PR99349] X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/master X-Git-Oldrev: 65c12e3894cac120c721c5d3fe94daa625ac8194 X-Git-Newrev: b6aa7d45b502c01f8703c8d2cee2690f9aa8e282 Message-Id: <20220902191207.B032C3858D1E@sourceware.org> Date: Fri, 2 Sep 2022 19:12:07 +0000 (GMT) List-Id: https://gcc.gnu.org/g:b6aa7d45b502c01f8703c8d2cee2690f9aa8e282 commit r13-2382-gb6aa7d45b502c01f8703c8d2cee2690f9aa8e282 Author: Harald Anlauf Date: Fri Sep 2 21:07:26 2022 +0200 Fortran: avoid NULL pointer dereference on invalid DATA constant [PR99349] gcc/fortran/ChangeLog: PR fortran/99349 * decl.cc (match_data_constant): Avoid NULL pointer dereference. gcc/testsuite/ChangeLog: PR fortran/99349 * gfortran.dg/pr99349.f90: New test. Co-authored-by: Steven G. Kargl Diff: --- gcc/fortran/decl.cc | 3 ++- gcc/testsuite/gfortran.dg/pr99349.f90 | 9 +++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/decl.cc b/gcc/fortran/decl.cc index b6400514731..0f9b2ced4c2 100644 --- a/gcc/fortran/decl.cc +++ b/gcc/fortran/decl.cc @@ -423,7 +423,8 @@ match_data_constant (gfc_expr **result) data-pointer-initialization compatible (7.5.4.6) with the initial data target; the data statement object is initially associated with the target. */ - if ((*result)->symtree->n.sym->attr.save + if ((*result)->symtree + && (*result)->symtree->n.sym->attr.save && (*result)->symtree->n.sym->attr.target) return m; gfc_free_expr (*result); diff --git a/gcc/testsuite/gfortran.dg/pr99349.f90 b/gcc/testsuite/gfortran.dg/pr99349.f90 new file mode 100644 index 00000000000..e1f4628af0b --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr99349.f90 @@ -0,0 +1,9 @@ +! { dg-do compile } +! PR fortran/99349 - ICE in match_data_constant +! Contributed by G.Steinmetz + +function f() + logical, parameter :: a((1.)/0) = .true. ! { dg-error "Parameter array" } + integer :: b + data b /a%kind/ ! { dg-error "Syntax error" } +end