From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id 7B6713854163; Sun, 4 Sep 2022 20:57:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7B6713854163 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1662325051; bh=bJP16FDaVDLAMRTzKewRuAVO9fsNEFoIq1t5LGnXjJ4=; h=From:To:Subject:Date:From; b=YZGQgzxSTVZozMMt6nBSr53kVASlZUcMyTUpbMcmSkzz0dseGcWZcoQG1f1G8KgWy 0szqOOQlC54/Ci9czgnwsgnSbXlrhWb31rF0h/nX5WL3ZgVltf2Y05TP4tOU5kBdqz 4oHWOHzuBz+3GogMr/eTOKypi7b35b0cTBvrcAlY= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2397] Fortran: Fix ICE with -fcheck=pointer [PR100136] X-Act-Checkin: gcc X-Git-Author: =?utf-8?q?Jos=C3=A9_Rui_Faustino_de_Sousa?= X-Git-Refname: refs/heads/master X-Git-Oldrev: 8b633b42af4ef82baf424ac5021d996a909f398c X-Git-Newrev: 20d30e737ad79dc36817e59f1676aa8bc0c6b325 Message-Id: <20220904205731.7B6713854163@sourceware.org> Date: Sun, 4 Sep 2022 20:57:31 +0000 (GMT) List-Id: https://gcc.gnu.org/g:20d30e737ad79dc36817e59f1676aa8bc0c6b325 commit r13-2397-g20d30e737ad79dc36817e59f1676aa8bc0c6b325 Author: José Rui Faustino de Sousa Date: Sun Sep 4 21:53:09 2022 +0200 Fortran: Fix ICE with -fcheck=pointer [PR100136] gcc/fortran/ChangeLog: PR fortran/100136 * trans-expr.cc (gfc_conv_procedure_call): Add handling of pointer expressions. gcc/testsuite/ChangeLog: PR fortran/100136 * gfortran.dg/PR100136.f90: New test. Diff: --- gcc/fortran/trans-expr.cc | 7 +++--- gcc/testsuite/gfortran.dg/PR100136.f90 | 39 ++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/gcc/fortran/trans-expr.cc b/gcc/fortran/trans-expr.cc index 13c3e7df45f..7895d034610 100644 --- a/gcc/fortran/trans-expr.cc +++ b/gcc/fortran/trans-expr.cc @@ -7220,16 +7220,15 @@ gfc_conv_procedure_call (gfc_se * se, gfc_symbol * sym, else goto end_pointer_check; + tmp = parmse.expr; if (fsym && fsym->ts.type == BT_CLASS) { - tmp = build_fold_indirect_ref_loc (input_location, - parmse.expr); + if (POINTER_TYPE_P (TREE_TYPE (tmp))) + tmp = build_fold_indirect_ref_loc (input_location, tmp); tmp = gfc_class_data_get (tmp); if (GFC_DESCRIPTOR_TYPE_P (TREE_TYPE (tmp))) tmp = gfc_conv_descriptor_data_get (tmp); } - else - tmp = parmse.expr; /* If the argument is passed by value, we need to strip the INDIRECT_REF. */ diff --git a/gcc/testsuite/gfortran.dg/PR100136.f90 b/gcc/testsuite/gfortran.dg/PR100136.f90 new file mode 100644 index 00000000000..922af4aecc3 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/PR100136.f90 @@ -0,0 +1,39 @@ +! { dg-do run } +! { dg-options "-fcheck=pointer" } +! { dg-shouldfail "Argument not allocated" } +! { dg-output "Fortran runtime error: Allocatable actual argument 'c_init2' is not allocated" } +! +! Tests fix for PR100136 +! +! Test cut down from PR58586 +! + +module test_pr58586_mod + implicit none + + type :: a + end type + + type :: c + type(a), allocatable :: a + end type + +contains + + subroutine add_class_c (d) + class(c), value :: d + end subroutine + + class(c) function c_init2() + allocatable :: c_init2 + end function + +end module test_pr58586_mod + +program test_pr58586 + use test_pr58586_mod + + ! This needs to execute, to see whether the segfault at runtime is resolved + call add_class_c(c_init2()) + +end program