From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7884) id 1687D3858CDA; Mon, 5 Sep 2022 14:26:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1687D3858CDA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1662387960; bh=4xb1b7Bltw2Sl306FPB5e1XKbwD/hNiebtAWTEQJB3s=; h=From:To:Subject:Date:From; b=eMwnR3GJpMXuxxntppmyaVxRfkOB8Hzi4+AGzIdIWLTYfHA4H1LG2dEsP3Xrg7oF4 5ahhlHuYPJuqDUyOqIviJL853B4joT8tkfTnNTMpG5ovpqQ4zEJ/JB/bzAK9JPEQLg Y8+D4wQfZjPCe1KY6leg6NIvgL/7BFcwA7Hx9BXo= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Tim Lange To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2441] analyzer: return a concrete offset for cast_regions X-Act-Checkin: gcc X-Git-Author: Tim Lange X-Git-Refname: refs/heads/master X-Git-Oldrev: ae97ba1efcd66d73d3631addf4c09f55e12d34f5 X-Git-Newrev: 1cc7e31c41a555c53d6f0a88ecd71bbf09b9dd8d Message-Id: <20220905142600.1687D3858CDA@sourceware.org> Date: Mon, 5 Sep 2022 14:26:00 +0000 (GMT) List-Id: https://gcc.gnu.org/g:1cc7e31c41a555c53d6f0a88ecd71bbf09b9dd8d commit r13-2441-g1cc7e31c41a555c53d6f0a88ecd71bbf09b9dd8d Author: Tim Lange Date: Sun Sep 4 13:07:34 2022 +0200 analyzer: return a concrete offset for cast_regions This patch fixes a bug where maybe_fold_sub_svalue did not fold the access of a single char from a string to a char when the offset was zero because get_relative_concrete_offset did return false for cast_regions. Regrtested on Linux x86_64. 2022-09-04 Tim Lange gcc/analyzer/ChangeLog: * region.cc (cast_region::get_relative_concrete_offset): New overloaded method. * region.h: Add cast_region::get_relative_concrete_offset. gcc/testsuite/ChangeLog: * gcc.dg/analyzer/fold-string-to-char.c: New test. Diff: --- gcc/analyzer/region.cc | 10 ++++++++++ gcc/analyzer/region.h | 2 ++ gcc/testsuite/gcc.dg/analyzer/fold-string-to-char.c | 8 ++++++++ 3 files changed, 20 insertions(+) diff --git a/gcc/analyzer/region.cc b/gcc/analyzer/region.cc index f4aba6b9c88..9c8279b130d 100644 --- a/gcc/analyzer/region.cc +++ b/gcc/analyzer/region.cc @@ -1556,6 +1556,16 @@ cast_region::dump_to_pp (pretty_printer *pp, bool simple) const } } +/* Implementation of region::get_relative_concrete_offset vfunc + for cast_region. */ + +bool +cast_region::get_relative_concrete_offset (bit_offset_t *out) const +{ + *out = (int) 0; + return true; +} + /* class heap_allocated_region : public region. */ /* Implementation of region::dump_to_pp vfunc for heap_allocated_region. */ diff --git a/gcc/analyzer/region.h b/gcc/analyzer/region.h index d37584b7285..34ce1fa1714 100644 --- a/gcc/analyzer/region.h +++ b/gcc/analyzer/region.h @@ -1087,6 +1087,8 @@ public: void accept (visitor *v) const final override; void dump_to_pp (pretty_printer *pp, bool simple) const final override; + bool get_relative_concrete_offset (bit_offset_t *out) const final override; + const region *get_original_region () const { return m_original_region; } private: diff --git a/gcc/testsuite/gcc.dg/analyzer/fold-string-to-char.c b/gcc/testsuite/gcc.dg/analyzer/fold-string-to-char.c new file mode 100644 index 00000000000..46139216bba --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/fold-string-to-char.c @@ -0,0 +1,8 @@ +#include "analyzer-decls.h" + +void test_1 (void) +{ + char str[] = "Hello"; + char *ptr = str; + __analyzer_eval (ptr[0] == 'H'); /* { dg-warning "TRUE" } */ +}