public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jiu Fu Guo <guojiufu@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-2507] rs6000: remove unused splitter on const_scalar_int_operand
Date: Wed,  7 Sep 2022 05:35:46 +0000 (GMT)	[thread overview]
Message-ID: <20220907053546.B06A2385694B@sourceware.org> (raw)

https://gcc.gnu.org/g:ea6e89e07f4223c8ac7877508c62bba368084999

commit r13-2507-gea6e89e07f4223c8ac7877508c62bba368084999
Author: Jiufu Guo <guojiufu@linux.ibm.com>
Date:   Wed Sep 7 13:32:55 2022 +0800

    rs6000: remove unused splitter on const_scalar_int_operand
    
    There are two splitters, both are calling rs6000_emit_set_const to emit
    instructions for constant building.
    One splitter checks `const_int_operand`, this splitter is always used.
    Another spitter checks `const_scalar_int_operand`, this one is never
    used now.
    
    Checking the history, that splitter is introduced around 1999 for
    HOST_BITS_PER_WIDE_INT=32, as below:
    
    (define_split
      [(set (match_operand:DI 0 "gpc_reg_operand" "")
            (match_operand:DI 1 "const_double_operand" ""))]
      "HOST_BITS_PER_WIDE_INT == 32 && TARGET_POWERPC64
       && num_insns_constant (operands[1], DImode) > 1"
    
    And `HOST_BITS_PER_WIDE_INT == 32` is eliminated later, since it is
    `const_double_operand` can cover it.
    When wide_int is introduced, `const_double_operand` is replaced by
    `const_scalar_int_operand`.
    
    Now, HOST_BITS_PER_WIDE_INT is forced to 64, this splitter is safe
    to remove.
    
    gcc/ChangeLog:
    
            * config/rs6000/rs6000.md (const_scalar_int splitter): Remove.

Diff:
---
 gcc/config/rs6000/rs6000.md | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/gcc/config/rs6000/rs6000.md b/gcc/config/rs6000/rs6000.md
index 85b97389d82..959fad23091 100644
--- a/gcc/config/rs6000/rs6000.md
+++ b/gcc/config/rs6000/rs6000.md
@@ -9712,18 +9712,6 @@
     FAIL;
 })
 
-(define_split
-  [(set (match_operand:DI 0 "int_reg_operand_not_pseudo")
-	(match_operand:DI 1 "const_scalar_int_operand"))]
-  "TARGET_POWERPC64 && num_insns_constant (operands[1], DImode) > 1"
-  [(pc)]
-{
-  if (rs6000_emit_set_const (operands[0], operands[1]))
-    DONE;
-  else
-    FAIL;
-})
-
 (define_split
   [(set (match_operand:DI 0 "altivec_register_operand")
 	(match_operand:DI 1 "s5bit_cint_operand"))]

                 reply	other threads:[~2022-09-07  5:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220907053546.B06A2385694B@sourceware.org \
    --to=guojiufu@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).