From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2122) id 5B707385841A; Wed, 7 Sep 2022 14:12:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B707385841A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1662559978; bh=s0ROoDmpzlgjS53gufrarEGt4klPKHVfwxHM2yRaTYM=; h=From:To:Subject:Date:From; b=m0K1xhbmqvrgFD7bNjKfyrtDZHlpN80s7rYdf850nDblfJYf78sk6acbL6PwOSXEY R2i22gkwolx1G1QH0PaNlQRWlKXzEmujEvBeMbJtavDFKKwhlLAmrU01V3eR4O4fVG 6y5akTboigpxU7SVpeKVJmrwzKpeG0W6M3gBK1Ac= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jason Merrill To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r13-2521] libstdc++: small dynamic_cast optimization X-Act-Checkin: gcc X-Git-Author: Jason Merrill X-Git-Refname: refs/heads/master X-Git-Oldrev: 0a91bdaf177409a2a5e7895bce4f0e7091b4b3ca X-Git-Newrev: 873d395c2976a8321cec03f21d77e11f746da7c0 Message-Id: <20220907141258.5B707385841A@sourceware.org> Date: Wed, 7 Sep 2022 14:12:58 +0000 (GMT) List-Id: https://gcc.gnu.org/g:873d395c2976a8321cec03f21d77e11f746da7c0 commit r13-2521-g873d395c2976a8321cec03f21d77e11f746da7c0 Author: Jason Merrill Date: Tue Sep 6 10:35:21 2022 -0400 libstdc++: small dynamic_cast optimization This change speeds up the simple benchmark below by about 40%. struct A { virtual ~A() {} }; struct B: A { } b; A* ap = &b; void *sink; int main() { for (long i = 0; i < 4000000000L; ++i) sink = dynamic_cast(ap); } libstdc++-v3/ChangeLog: * libsupc++/dyncast.cc (__dynamic_cast): Avoid virtual function call in simple success case. Diff: --- libstdc++-v3/libsupc++/dyncast.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libstdc++-v3/libsupc++/dyncast.cc b/libstdc++-v3/libsupc++/dyncast.cc index 853c911a4cf..616e4c05766 100644 --- a/libstdc++-v3/libsupc++/dyncast.cc +++ b/libstdc++-v3/libsupc++/dyncast.cc @@ -71,6 +71,12 @@ __dynamic_cast (const void *src_ptr, // object started from if (whole_prefix->whole_type != whole_type) return NULL; + // Avoid virtual function call in the simple success case. + if (src2dst >= 0 + && src2dst == -prefix->whole_object + && *whole_type == *dst_type) + return const_cast (whole_ptr); + whole_type->__do_dyncast (src2dst, __class_type_info::__contained_public, dst_type, whole_ptr, src_type, src_ptr, result); if (!result.dst_ptr)