public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Michael Meissner <meissner@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc(refs/users/meissner/heads/work100)] Add 'w' suffix for __ibm128 constants.
Date: Fri,  9 Sep 2022 18:21:26 +0000 (GMT)	[thread overview]
Message-ID: <20220909182126.AC10B3857359@sourceware.org> (raw)

https://gcc.gnu.org/g:53e9f1bbe7d6a94d89948f1287d98ebaa59b9db0

commit 53e9f1bbe7d6a94d89948f1287d98ebaa59b9db0
Author: Michael Meissner <meissner@linux.ibm.com>
Date:   Fri Sep 9 14:18:47 2022 -0400

    Add 'w' suffix for __ibm128 constants.
    
    In the documentation, we mention that 'w' or 'W' can be used as a suffix for
    __ibm128 constants.  We never implemented this.  This patch fixes that.
    
    In addition, the 'q' and 'Q' suffix were changed to use the mode used for the
    __float128 type, instead of knowing whether to use KFmode or TFmode explicitly.
    This will be used in a future patch where we change the mode used for __float128
    on systems where long double is IEEE 128-bit.
    
    2022-09-09   Michael Meissner  <meissner@linux.ibm.com>
    
    gcc/
    
            * config/rs6000/rs6000.cc (rs6000_c_mode_for_suffix): Allow 'w' or 'W'
            for __ibm128 constants.
    
    gcc/testsuite/
    
            * gcc.target/powerpc/ibm128-suffix.c: New test.

Diff:
---
 gcc/config/rs6000/rs6000.cc                      | 25 ++++++++++++------------
 gcc/testsuite/gcc.target/powerpc/ibm128-suffix.c | 13 ++++++++++++
 2 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc
index 1c5436208f1..49d9017e4ca 100644
--- a/gcc/config/rs6000/rs6000.cc
+++ b/gcc/config/rs6000/rs6000.cc
@@ -23850,22 +23850,23 @@ rs6000_floatn_mode (int n, bool extended)
 
 }
 
-/* Target hook for c_mode_for_suffix.  */
+/* Target hook for c_mode_for_suffix.  We use TYPE_MODE to follow the mode used
+   for __float128 and __ibm128.
+
+   Only two suffixes are allowed, 'q' and 'w'.  The 'q' suffix is used for
+   float128 constants on both the x86 and PowerPC processors.  Its use predates
+   the use of 'f128' for _Float128 constants, and existing code still uses it.
+
+   The 'w' suffix was used on the x86 processors for their 80-bit long
+   double.  We use it for __ibm128 constants.  */
 static machine_mode
 rs6000_c_mode_for_suffix (char suffix)
 {
-  if (TARGET_FLOAT128_TYPE)
-    {
-      if (suffix == 'q' || suffix == 'Q')
-	return (FLOAT128_IEEE_P (TFmode)) ? TFmode : KFmode;
+  if (TARGET_FLOAT128_TYPE && (suffix == 'q' || suffix == 'Q'))
+    return TYPE_MODE (ieee128_float_type_node);
 
-      /* At the moment, we are not defining a suffix for IBM extended double.
-	 If/when the default for -mabi=ieeelongdouble is changed, and we want
-	 to support __ibm128 constants in legacy library code, we may need to
-	 re-evalaute this decision.  Currently, c-lex.cc only supports 'w' and
-	 'q' as machine dependent suffixes.  The x86_64 port uses 'w' for
-	 __float80 constants.  */
-    }
+  if (TARGET_IBM128 && (suffix == 'w' || suffix == 'W'))
+    return TYPE_MODE (ibm128_float_type_node);
 
   return VOIDmode;
 }
diff --git a/gcc/testsuite/gcc.target/powerpc/ibm128-suffix.c b/gcc/testsuite/gcc.target/powerpc/ibm128-suffix.c
new file mode 100644
index 00000000000..ff619860409
--- /dev/null
+++ b/gcc/testsuite/gcc.target/powerpc/ibm128-suffix.c
@@ -0,0 +1,13 @@
+/* { dg-do compile } */
+/* { dg-require-effective-target longdouble128 } */
+/* { dg-options "-O2" } */
+
+/* See if the 'w' suffix is accepted for __ibm128.  */
+#ifndef NUMBER
+#define NUMBER  123456789012345678901234567890123456789E-10
+#endif
+
+#define GLUE2(X,Y)      X ## Y
+#define GLUE(X,Y)       GLUE2(X,Y)
+
+__ibm128 x = GLUE (NUMBER, w);

                 reply	other threads:[~2022-09-09 18:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220909182126.AC10B3857359@sourceware.org \
    --to=meissner@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).