public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-2637] aarch64: Disassociate ls64 from simd
Date: Tue, 13 Sep 2022 08:29:07 +0000 (GMT)	[thread overview]
Message-ID: <20220913082907.E7C503858C53@sourceware.org> (raw)

https://gcc.gnu.org/g:91061fd5ace2b8ee6bf31bf5f5cbfdf55a25d5e1

commit r13-2637-g91061fd5ace2b8ee6bf31bf5f5cbfdf55a25d5e1
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Tue Sep 13 09:28:48 2022 +0100

    aarch64: Disassociate ls64 from simd
    
    The ls64-related move expanders and splits required TARGET_SIMD.
    That isn't necessary, since the 64-byte values are stored entirely
    in GPRs.  (The associated define_insn was already correct.)
    
    I wondered about moving the patterns to aarch64.md, but it wasn't
    clear-cut.
    
    gcc/
            * config/aarch64/aarch64-simd.md (movv8di): Remove TARGET_SIMD
            condition.  Likewise for the related define_split.  Tweak formatting.
    
    gcc/testsuite/
            * gcc.target/aarch64/acle/ls64_asm_2.c: New test.

Diff:
---
 gcc/config/aarch64/aarch64-simd.md                 | 18 +++++++++---------
 gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c |  9 +++++++++
 2 files changed, 18 insertions(+), 9 deletions(-)

diff --git a/gcc/config/aarch64/aarch64-simd.md b/gcc/config/aarch64/aarch64-simd.md
index 587a45d7772..d4662c76a58 100644
--- a/gcc/config/aarch64/aarch64-simd.md
+++ b/gcc/config/aarch64/aarch64-simd.md
@@ -7087,7 +7087,7 @@
 (define_expand "movv8di"
   [(set (match_operand:V8DI 0 "nonimmediate_operand")
 	(match_operand:V8DI 1 "general_operand"))]
-  "TARGET_SIMD"
+  ""
 {
   if (can_create_pseudo_p () && MEM_P (operands[0]))
     operands[1] = force_reg (V8DImode, operands[1]);
@@ -7479,7 +7479,7 @@
 (define_split
   [(set (match_operand:V8DI 0 "nonimmediate_operand")
         (match_operand:V8DI 1 "general_operand"))]
-  "TARGET_SIMD && reload_completed"
+  "reload_completed"
   [(const_int 0)]
 {
   if (register_operand (operands[0], V8DImode)
@@ -7489,15 +7489,15 @@
       DONE;
     }
   else if ((register_operand (operands[0], V8DImode)
-            && memory_operand (operands[1], V8DImode))
-           || (memory_operand (operands[0], V8DImode)
-            && register_operand (operands[1], V8DImode)))
+	    && memory_operand (operands[1], V8DImode))
+	   || (memory_operand (operands[0], V8DImode)
+	       && register_operand (operands[1], V8DImode)))
     {
       for (int offset = 0; offset < 64; offset += 16)
-        emit_move_insn (simplify_gen_subreg (TImode, operands[0],
-                                             V8DImode, offset),
-                        simplify_gen_subreg (TImode, operands[1],
-                                             V8DImode, offset));
+	emit_move_insn (simplify_gen_subreg (TImode, operands[0],
+					     V8DImode, offset),
+			simplify_gen_subreg (TImode, operands[1],
+					     V8DImode, offset));
       DONE;
     }
   else
diff --git a/gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c b/gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c
new file mode 100644
index 00000000000..1b4277180a6
--- /dev/null
+++ b/gcc/testsuite/gcc.target/aarch64/acle/ls64_asm_2.c
@@ -0,0 +1,9 @@
+/* { dg-do compile } */
+/* { dg-options "-O" } */
+
+#pragma GCC target "+ls64+nofp"
+
+#include "ls64_asm.c"
+
+/* { dg-final { scan-assembler-times {\tldp\t} 12 } } */
+/* { dg-final { scan-assembler-times {\tstp\t} 4 } } */

                 reply	other threads:[~2022-09-13  8:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220913082907.E7C503858C53@sourceware.org \
    --to=rsandifo@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).