From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2153) id 287F03858D1E; Tue, 13 Sep 2022 17:04:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 287F03858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663088663; bh=naWr+KVd18DSsq2QVxGOhlgYAIV+FkTZm1ZOKh1meuA=; h=From:To:Subject:Date:From; b=hCbwt9W8BZo+WQAzfaJmh0J/LdvB3IDs/6a1UAbhueUiL6C4VWZiZsQCQmoTIaHDB /WE1jeeUkoEcK6g7zY8nN0W4C+Hw0ZcqxwgWdZ7B0VU9GiV5iSVJeB7VQwelNbTkTk b8uh0FyfOLIgKy8fnNtgnQ+Ikkd6cPNlBnBSqC4A= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jakub Jelinek To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2652] libgomp: Appease some static analyzers [PR106906] X-Act-Checkin: gcc X-Git-Author: Jakub Jelinek X-Git-Refname: refs/heads/master X-Git-Oldrev: 7d7e2149cdb6b0c37e01df7745cb551fbed317f6 X-Git-Newrev: e11babbfac21163118b69dd25b468ade80dbe8de Message-Id: <20220913170423.287F03858D1E@sourceware.org> Date: Tue, 13 Sep 2022 17:04:23 +0000 (GMT) List-Id: https://gcc.gnu.org/g:e11babbfac21163118b69dd25b468ade80dbe8de commit r13-2652-ge11babbfac21163118b69dd25b468ade80dbe8de Author: Jakub Jelinek Date: Tue Sep 13 19:00:02 2022 +0200 libgomp: Appease some static analyzers [PR106906] While icv_addr[1] = false; assignments where icv_addr has void * element type is correct and matches how it is used (in those cases the void * pointer is then cast to bool and used that way), there is no reason not to add explicit (void *) casts there which are there already for (void *) true. And, there is in fact even no point in actually doing those stores at all because we set that pointer to NULL a few lines earlier. So, this patch adds the explicit casts and then comments those out to show intent. 2022-09-13 Jakub Jelinek PR libgomp/106906 * env.c (get_icv_member_addr): Cast false to void * before assigning it to icv_addr[1], and comment the whole assignment out. Diff: --- libgomp/env.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libgomp/env.c b/libgomp/env.c index ac8c764db60..0249966e8a6 100644 --- a/libgomp/env.c +++ b/libgomp/env.c @@ -1892,14 +1892,14 @@ get_icv_member_addr (struct gomp_initial_icvs *icvs, int icv_code, { case GOMP_ICV_NTEAMS: icv_addr[0] = &icvs->nteams_var; - icv_addr[1] = false; + /* icv_addr[1] = (void *) false; */ break; case GOMP_ICV_DYNAMIC: icv_addr[0] = &(*icvs).dyn_var; break; case GOMP_ICV_TEAMS_THREAD_LIMIT: icv_addr[0] = &icvs->teams_thread_limit_var; - icv_addr[1] = false; + /* icv_addr[1] = (void *) false; */ break; case GOMP_ICV_SCHEDULE: icv_addr[0] = &icvs->run_sched_var; @@ -1907,7 +1907,7 @@ get_icv_member_addr (struct gomp_initial_icvs *icvs, int icv_code, break; case GOMP_ICV_THREAD_LIMIT: icv_addr[0] = &icvs->thread_limit_var; - icv_addr[1] = false; + /* icv_addr[1] = (void *) false; */ icv_addr[2] = (void *) UINT_MAX; break; case GOMP_ICV_NTHREADS: