From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id 523DD3858427; Wed, 14 Sep 2022 12:49:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 523DD3858427 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663159741; bh=v9lXqhC6Ge2pfPFrDFZXUUAZsZB/xXGyd27BlPAE4Mw=; h=From:To:Subject:Date:From; b=W4OOLU8PLWSE5FQV5SoWxdEEGWsK/eOO3HQP7J3NXF7RlnzyQ8B+aWDoyJJQb4nEg cWn2Ch+RPBAeFJK/2KJe3c/pJ6mNXnRtfXvXJdM52El1izg/BsRuRRB/sIfIC+V/KZ JaX8v5Jwtd/SSd+jaaCWZ0mjRvL+v1CyL3yDekyA= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2663] [PR106936] Remove assert from get_value_range. X-Act-Checkin: gcc X-Git-Author: Aldy Hernandez X-Git-Refname: refs/heads/master X-Git-Oldrev: 1457be6dbd78e1fd2f84584e020f9a2b3803181a X-Git-Newrev: 12a8d5e2f2e7d7535115e4e105c0f9eb4d50fdad Message-Id: <20220914124901.523DD3858427@sourceware.org> Date: Wed, 14 Sep 2022 12:49:01 +0000 (GMT) List-Id: https://gcc.gnu.org/g:12a8d5e2f2e7d7535115e4e105c0f9eb4d50fdad commit r13-2663-g12a8d5e2f2e7d7535115e4e105c0f9eb4d50fdad Author: Aldy Hernandez Date: Wed Sep 14 14:48:36 2022 +0200 [PR106936] Remove assert from get_value_range. This assert was put here to make sure that the legacy get_value_range() wasn't being called on stuff that legacy couldn't handle (floats, etc), because the result would ultimately be copied into a value_range_equiv. In this case, simplify_casted_cond() is calling it on an offset_type which is neither an integer nor a pointer. However, range_of_expr happily punted on it, and then the fallthru code set the range to VARYING. As value_range_equiv can store VARYING types of anything (including types it can't handle), this is fine. The easiest thing to do is remove the assert. If someone from the non legacy world tries to get a non integer/pointer range here, it's going to blow up anyhow because the temporary in get_value_range is int_range_max. PR tree-optimization/106936 gcc/ChangeLog: * value-query.cc (range_query::get_value_range): Remove assert. gcc/testsuite/ChangeLog: * g++.dg/tree-ssa/pr106936.C: New test. Diff: --- gcc/testsuite/g++.dg/tree-ssa/pr106936.C | 14 ++++++++++++++ gcc/value-query.cc | 1 - 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/g++.dg/tree-ssa/pr106936.C b/gcc/testsuite/g++.dg/tree-ssa/pr106936.C new file mode 100644 index 00000000000..c3096e0dd20 --- /dev/null +++ b/gcc/testsuite/g++.dg/tree-ssa/pr106936.C @@ -0,0 +1,14 @@ +// { dg-do compile } */ +// { dg-options "-O2 -fno-tree-ccp -fno-tree-forwprop -fno-tree-fre" } + +namespace testPointerToMemberMiscCasts2 { +struct B { + int f; +}; +struct L : public B { }; +struct R : public B { }; +struct D : public L, R { }; + int B::* pb = &B::f; + int R::* pr = pb; + int D::* pdr = pr; +} diff --git a/gcc/value-query.cc b/gcc/value-query.cc index 201f679a36e..ad80db780c2 100644 --- a/gcc/value-query.cc +++ b/gcc/value-query.cc @@ -167,7 +167,6 @@ range_query::free_value_range_equiv (value_range_equiv *v) const class value_range_equiv * range_query::get_value_range (const_tree expr, gimple *stmt) { - gcc_checking_assert (value_range_equiv::supports_p (TREE_TYPE (expr))); int_range_max r; if (range_of_expr (r, const_cast (expr), stmt)) return new (equiv_alloc->allocate ()) value_range_equiv (r);