From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id 68372384BC3C; Fri, 16 Sep 2022 19:11:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68372384BC3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663355496; bh=JM2isNFZlTrst+xmXqf9zn3u+x9SQEeQ3M2e1eXjAM4=; h=From:To:Subject:Date:From; b=n0mgJjHOVX/l812FVhV2N0cql69UCG7qMH1s8k/XHk5UnbzYfbqWfjMqBlzKI5XxM B6ggxxOkKFp8/qMakTn3Sbg/5GgLcVMZT2dDnTnMiaDGZ2kQmMdWZOmUn00B2JKVH6 hRB0qqkkoahQeE6vWGdoVZ8l/mIPI+j66euRCuMk= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r12-8769] Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857] X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: 9035eaaf028ca609660f1f55c0d9f22fb7d3b797 X-Git-Newrev: f5023ce74f882b7f7c8cf41e70cc7380ba0eba06 Message-Id: <20220916191136.68372384BC3C@sourceware.org> Date: Fri, 16 Sep 2022 19:11:36 +0000 (GMT) List-Id: https://gcc.gnu.org/g:f5023ce74f882b7f7c8cf41e70cc7380ba0eba06 commit r12-8769-gf5023ce74f882b7f7c8cf41e70cc7380ba0eba06 Author: Harald Anlauf Date: Thu Sep 15 22:39:24 2022 +0200 Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857] gcc/fortran/ChangeLog: PR fortran/106857 * simplify.cc (gfc_simplify_pack): Check for NULL pointer dereferences while walking through constructors (error recovery). gcc/testsuite/ChangeLog: PR fortran/106857 * gfortran.dg/pr106857.f90: New test. (cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24) Diff: --- gcc/fortran/simplify.cc | 2 +- gcc/testsuite/gfortran.dg/pr106857.f90 | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/simplify.cc b/gcc/fortran/simplify.cc index 1d74cf35a25..0eff5a546cc 100644 --- a/gcc/fortran/simplify.cc +++ b/gcc/fortran/simplify.cc @@ -6393,7 +6393,7 @@ gfc_simplify_pack (gfc_expr *array, gfc_expr *mask, gfc_expr *vector) /* Copy only those elements of ARRAY to RESULT whose MASK equals .TRUE.. */ mask_ctor = gfc_constructor_first (mask->value.constructor); - while (mask_ctor) + while (mask_ctor && array_ctor) { if (mask_ctor->expr->value.logical) { diff --git a/gcc/testsuite/gfortran.dg/pr106857.f90 b/gcc/testsuite/gfortran.dg/pr106857.f90 new file mode 100644 index 00000000000..4b0f86a75a6 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr106857.f90 @@ -0,0 +1,12 @@ +! { dg-do compile } +! PR fortran/106857 - ICE in gfc_simplify_pack +! Contributed by G.Steinmetz + +program p + type t + integer :: n + end type + type(t), parameter :: a(2,2) = t(1) + type(t), parameter :: b(4) = reshape(a, [2]) ! { dg-error "Different shape" } + type(t), parameter :: c(2) = pack(b, [.false.,.true.,.false.,.true.]) ! { dg-error "Different shape" } +end