public inbox for
help / color / mirror / Atom feed
* [gcc r13-2711] Fix unsigned comparison warning
@ 2022-09-17 13:41 Jan-Benedict Glaw
  0 siblings, 0 replies; only message in thread
From: Jan-Benedict Glaw @ 2022-09-17 13:41 UTC (permalink / raw)
  To: gcc-cvs

commit r13-2711-gc8e93a08693cdd8e18f129f3a1918ed3d32eeebe
Author: Jan-Benedict Glaw <>
Date:   Sat Sep 17 15:40:28 2022 +0200

    Fix unsigned comparison warning
    When -mfloat-abi=hard support was added, a cast went missing that
    used to silence a warning in common code:
    /usr/lib/gcc-snapshot/bin/g++  -fno-PIE -c   -g -O2   -DIN_GCC  -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common  -DHAVE_CONFIG_H -I. -I. -I../../gcc/gcc -I../../gcc/gcc/. -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libcody  -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace   -o builtins.o -MT builtins.o -MMD -MP -MF ./.deps/builtins.TPo ../../gcc/gcc/
    In file included from ./tm.h:21,
                     from ../../gcc/gcc/backend.h:28,
                     from ../../gcc/gcc/
    ../../gcc/gcc/ In function 'int apply_args_size()':
    ../../gcc/gcc/config/csky/csky.h:421:13: error: comparison of unsigned expression in '>= 0' is always true [-Werror=type-limits]
      421 |   (((REGNO) >= CSKY_FIRST_PARM_REGNUM                        \
    ../../gcc/gcc/ note: in expansion of macro 'FUNCTION_ARG_REGNO_P'
     1444 |         if (FUNCTION_ARG_REGNO_P (regno))
          |             ^~~~~~~~~~~~~~~~~~~~
    cc1plus: all warnings being treated as errors
    make[1]: *** [Makefile:1146: builtins.o] Error 1
    The needed (int) cast is even mentioned in the comment above, so reinstate
    it here.
            * config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int)
            to prevent warning.

 gcc/config/csky/csky.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/csky/csky.h b/gcc/config/csky/csky.h
index f786ad55d43..a9d13691db3 100644
--- a/gcc/config/csky/csky.h
+++ b/gcc/config/csky/csky.h
@@ -422,7 +422,7 @@ typedef struct
    The int cast is to prevent a complaint about unsigned comparison to
    zero, since CSKY_FIRST_PARM_REGNUM is zero.  */
 #define FUNCTION_ARG_REGNO_P(REGNO)                          \
-  (((REGNO) >= CSKY_FIRST_PARM_REGNUM                        \
+  (((int)(REGNO) >= CSKY_FIRST_PARM_REGNUM                   \

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-09-17 13:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-17 13:41 [gcc r13-2711] Fix unsigned comparison warning Jan-Benedict Glaw

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).