From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2136) id 84B9C3858C55; Tue, 20 Sep 2022 17:36:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84B9C3858C55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663695398; bh=iV1z+C3Vm8Y03NPNIrdY/0Wo2QyUOYp8ah9IOlIk9ds=; h=From:To:Subject:Date:From; b=eizEpSzbB5IFXQlIeMgeNSI9aljHPKHSfKzHmKGEn7MO5ax2l/3T5A731rtGAoFv2 nxOdg7lOYLYQuwxpxhNm5Cvz7M1zdpMif1u5t5SzDwIddtvPWaZaLQjQTkZQ7DYAKf qAk65ELW7mJEbKQYLsn77oXQ3IuPWh9h+3t4jMOY= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Aldy Hernandez To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2741] frange::set_nonnegative should not contain -NAN. X-Act-Checkin: gcc X-Git-Author: Aldy Hernandez X-Git-Refname: refs/heads/master X-Git-Oldrev: d812e8cb2a920fd75768e16ca8ded59ad93c172f X-Git-Newrev: 10d6109fe183d984a0377a7afe2854a0d794ebeb Message-Id: <20220920173638.84B9C3858C55@sourceware.org> Date: Tue, 20 Sep 2022 17:36:38 +0000 (GMT) List-Id: https://gcc.gnu.org/g:10d6109fe183d984a0377a7afe2854a0d794ebeb commit r13-2741-g10d6109fe183d984a0377a7afe2854a0d794ebeb Author: Aldy Hernandez Date: Mon Sep 19 09:59:01 2022 +0200 frange::set_nonnegative should not contain -NAN. A specifically nonnegative range should not contain -NAN, otherwise signbit_p() would return false, because we'd be unsure of the sign. PR 68097/tree-optimization gcc/ChangeLog: * value-range.cc (frange::set_nonnegative): Set +NAN. (range_tests_signed_zeros): New test. * value-range.h (frange::update_nan): New overload to set NAN sign. Diff: --- gcc/value-range.cc | 9 +++++++++ gcc/value-range.h | 14 ++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/gcc/value-range.cc b/gcc/value-range.cc index a8e3bb39bab..dc42b6d3120 100644 --- a/gcc/value-range.cc +++ b/gcc/value-range.cc @@ -775,6 +775,10 @@ void frange::set_nonnegative (tree type) { set (type, dconst0, dconstinf); + + // Set +NAN as the only possibility. + if (HONOR_NANS (type)) + update_nan (/*sign=*/0); } // Here we copy between any two irange's. The ranges can be legacy or @@ -3823,6 +3827,11 @@ range_tests_signed_zeros () r1.update_nan (); r0.intersect (r1); ASSERT_TRUE (r0.known_isnan ()); + + r0.set_nonnegative (float_type_node); + ASSERT_TRUE (r0.signbit_p (signbit) && !signbit); + if (HONOR_NANS (float_type_node)) + ASSERT_TRUE (r0.maybe_isnan ()); } static void diff --git a/gcc/value-range.h b/gcc/value-range.h index 795b1f00fdc..7d5584a9294 100644 --- a/gcc/value-range.h +++ b/gcc/value-range.h @@ -312,6 +312,7 @@ public: const REAL_VALUE_TYPE &lower_bound () const; const REAL_VALUE_TYPE &upper_bound () const; void update_nan (); + void update_nan (bool sign); void clear_nan (); // fpclassify like API @@ -1099,6 +1100,19 @@ frange::update_nan () verify_range (); } +// Like above, but set the sign of the NAN. + +inline void +frange::update_nan (bool sign) +{ + gcc_checking_assert (!undefined_p ()); + m_pos_nan = !sign; + m_neg_nan = sign; + normalize_kind (); + if (flag_checking) + verify_range (); +} + // Clear the NAN bit and adjust the range. inline void