From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id EB68E3858C2F; Tue, 20 Sep 2022 20:26:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB68E3858C2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663705610; bh=HrebYGEZCztb45VP/187/JYMjzDTL/uScIKZmFfec6c=; h=From:To:Subject:Date:From; b=F35wO3VabJmcJZaw1NtDtQxNrq0rl2jpqgtfl0IJriQZdKT9u2Zwb1i/SQ6wBbmNw W2CA9V0hRxGc8RaVmrzzwZdALFUTXepEbcwCTmmBpQHDTOOsJxGRhUjRVktE+PBOX1 671Dzt66uowfwDGmqG8Pj8ymrY3VjKzIUbLYhli0= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2746] Fortran: NULL pointer dereference in invalid simplification [PR106985] X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/master X-Git-Oldrev: c77f556741ded4aa868f851ea32f9732602b0ea9 X-Git-Newrev: 8dbb15bc2d019488240c1e69d93121b0347ac092 Message-Id: <20220920202650.EB68E3858C2F@sourceware.org> Date: Tue, 20 Sep 2022 20:26:50 +0000 (GMT) List-Id: https://gcc.gnu.org/g:8dbb15bc2d019488240c1e69d93121b0347ac092 commit r13-2746-g8dbb15bc2d019488240c1e69d93121b0347ac092 Author: Harald Anlauf Date: Tue Sep 20 22:23:43 2022 +0200 Fortran: NULL pointer dereference in invalid simplification [PR106985] gcc/fortran/ChangeLog: PR fortran/106985 * expr.cc (gfc_simplify_expr): Avoid NULL pointer dereference. gcc/testsuite/ChangeLog: PR fortran/106985 * gfortran.dg/pr106985.f90: New test. Diff: --- gcc/fortran/expr.cc | 3 ++- gcc/testsuite/gfortran.dg/pr106985.f90 | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/expr.cc b/gcc/fortran/expr.cc index be94c18c836..290ddf360c8 100644 --- a/gcc/fortran/expr.cc +++ b/gcc/fortran/expr.cc @@ -2287,7 +2287,8 @@ gfc_simplify_expr (gfc_expr *p, int type) initialization expression, or we want a subsection. */ if (p->symtree->n.sym->attr.flavor == FL_PARAMETER && (gfc_init_expr_flag || p->ref - || p->symtree->n.sym->value->expr_type != EXPR_ARRAY)) + || (p->symtree->n.sym->value + && p->symtree->n.sym->value->expr_type != EXPR_ARRAY))) { if (!simplify_parameter_variable (p, type)) return false; diff --git a/gcc/testsuite/gfortran.dg/pr106985.f90 b/gcc/testsuite/gfortran.dg/pr106985.f90 new file mode 100644 index 00000000000..f4ed92577a3 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr106985.f90 @@ -0,0 +1,8 @@ +! { dg-do compile } +! PR fortran/106985 - ICE in gfc_simplify_expr +! Contributed by G.Steinmetz + +program p + integer, parameter :: a(2) = 1 + integer, parameter :: b = a(2) + b ! { dg-error "before its definition is complete" } +end