From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2078) id 7DC0C3851C37; Wed, 21 Sep 2022 07:47:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DC0C3851C37 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663746479; bh=Czs8YFoWH3zDZ+wSpnqaDrnd+73bRPiAWR49UWrF5aY=; h=From:To:Subject:Date:From; b=P93CjkCPvA9ZCsHTvbh+ckAquNMz0jD86vJmD51FdPhOm0/zA/sRl0xWKhI9lHmGA teNgxo78XgtFF9oRedw2A7Z38cELWCIsnvwt8NZkIHo0edCrtxYyFjq5uIPcxEIC4z 8NmVv7YWFp5udgAtxBDZGGlO7ihpVA+Ra5J664kk= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: hongtao Liu To: gcc-cvs@gcc.gnu.org Subject: [gcc r13-2754] Don't check can_vec_perm_const_p for nonlinear iv_init when it's constant. X-Act-Checkin: gcc X-Git-Author: liuhongt X-Git-Refname: refs/heads/master X-Git-Oldrev: 9c23fe08c1fcee524503b24e15321b20df136f6c X-Git-Newrev: eddbb81f1254f025d6f1b6b8e7554aa9a3830302 Message-Id: <20220921074759.7DC0C3851C37@sourceware.org> Date: Wed, 21 Sep 2022 07:47:59 +0000 (GMT) List-Id: https://gcc.gnu.org/g:eddbb81f1254f025d6f1b6b8e7554aa9a3830302 commit r13-2754-geddbb81f1254f025d6f1b6b8e7554aa9a3830302 Author: liuhongt Date: Tue Sep 20 13:22:28 2022 +0800 Don't check can_vec_perm_const_p for nonlinear iv_init when it's constant. When init_expr is INTEGER_CST or REAL_CST, can_vec_perm_const_p is not necessary since there's no real vec_perm needed, but vec_gen_perm_mask_checked will gcc_assert (can_vec_perm_const_p). So it's better to use vec_gen_perm_mask_any in vect_create_nonlinear_iv_init. gcc/ChangeLog: PR tree-optimization/106963 * tree-vect-loop.cc (vect_create_nonlinear_iv_init): Use vec_gen_perm_mask_any instead of vec_gen_perm_mask_check. gcc/testsuite/ChangeLog: * gcc.target/i386/pr106963.c: New test. Diff: --- gcc/testsuite/gcc.target/i386/pr106963.c | 14 ++++++++++++++ gcc/tree-vect-loop.cc | 5 ++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.target/i386/pr106963.c b/gcc/testsuite/gcc.target/i386/pr106963.c new file mode 100644 index 00000000000..9f2d20e2523 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr106963.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -mavx -mno-avx2" } */ + +void +foo_neg_const (int *a) +{ + int i, b = 1; + + for (i = 0; i < 1000; i++) + { + a[i] = b; + b = -b; + } +} diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index 9c434b66c5b..aabdc6f2d81 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -8356,8 +8356,11 @@ vect_create_nonlinear_iv_init (gimple_seq* stmts, tree init_expr, sel[2 * i + 1] = i + nunits; } vec_perm_indices indices (sel, 2, nunits); + /* Don't use vect_gen_perm_mask_checked since can_vec_perm_const_p may + fail when vec_init is const vector. In that situation vec_perm is not + really needed. */ tree perm_mask_even - = vect_gen_perm_mask_checked (vectype, indices); + = vect_gen_perm_mask_any (vectype, indices); vec_init = gimple_build (stmts, VEC_PERM_EXPR, vectype, vec_init, vec_neg,