From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2071) id 2E5A83858D38; Thu, 22 Sep 2022 18:37:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2E5A83858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1663871838; bh=jfWTZmyuBFK9mlEAJ7C7MOL+970YHbqCFhDzmxQDx8I=; h=From:To:Subject:Date:From; b=wh0wCFzrayM58C8tngd9MGva3n6Um9bsCGfgxSX09uC4ETGVzrCaaNNIR4o6mC8Br BRgSOK2VsfNSmmKgSlJiakPBXLbUZ17o+kruo1u/Kk3XTZXtp1fDz+AW6vgQGXQax1 TlZz0+VtbmMwL//wNE9KDXJBQAUxtzhzOo2yy5MM= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Harald Anlauf To: gcc-cvs@gcc.gnu.org Subject: [gcc r10-10998] Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857] X-Act-Checkin: gcc X-Git-Author: Harald Anlauf X-Git-Refname: refs/heads/releases/gcc-10 X-Git-Oldrev: d83b6e042c74e941622ca9f093839331171d610f X-Git-Newrev: cf172d0cdf355042223a3b1ebc04b472386a954e Message-Id: <20220922183718.2E5A83858D38@sourceware.org> Date: Thu, 22 Sep 2022 18:37:18 +0000 (GMT) List-Id: https://gcc.gnu.org/g:cf172d0cdf355042223a3b1ebc04b472386a954e commit r10-10998-gcf172d0cdf355042223a3b1ebc04b472386a954e Author: Harald Anlauf Date: Thu Sep 15 22:39:24 2022 +0200 Fortran: catch NULL pointer dereferences while simplifying PACK [PR106857] gcc/fortran/ChangeLog: PR fortran/106857 * simplify.c (gfc_simplify_pack): Check for NULL pointer dereferences while walking through constructors (error recovery). gcc/testsuite/ChangeLog: PR fortran/106857 * gfortran.dg/pr106857.f90: New test. (cherry picked from commit 2b75d5f533b9d6b39f4055949aff64ed0d22dd24) Diff: --- gcc/fortran/simplify.c | 2 +- gcc/testsuite/gfortran.dg/pr106857.f90 | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/gcc/fortran/simplify.c b/gcc/fortran/simplify.c index 29d4c695302..b3d73935771 100644 --- a/gcc/fortran/simplify.c +++ b/gcc/fortran/simplify.c @@ -6293,7 +6293,7 @@ gfc_simplify_pack (gfc_expr *array, gfc_expr *mask, gfc_expr *vector) /* Copy only those elements of ARRAY to RESULT whose MASK equals .TRUE.. */ mask_ctor = gfc_constructor_first (mask->value.constructor); - while (mask_ctor) + while (mask_ctor && array_ctor) { if (mask_ctor->expr->value.logical) { diff --git a/gcc/testsuite/gfortran.dg/pr106857.f90 b/gcc/testsuite/gfortran.dg/pr106857.f90 new file mode 100644 index 00000000000..4b0f86a75a6 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr106857.f90 @@ -0,0 +1,12 @@ +! { dg-do compile } +! PR fortran/106857 - ICE in gfc_simplify_pack +! Contributed by G.Steinmetz + +program p + type t + integer :: n + end type + type(t), parameter :: a(2,2) = t(1) + type(t), parameter :: b(4) = reshape(a, [2]) ! { dg-error "Different shape" } + type(t), parameter :: c(2) = pack(b, [.false.,.true.,.false.,.true.]) ! { dg-error "Different shape" } +end