public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Marek Polacek <mpolacek@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-2803] c++: ICE-on-invalid with designated initializer [PR106983]
Date: Fri, 23 Sep 2022 00:24:27 +0000 (GMT)	[thread overview]
Message-ID: <20220923002427.8E0403858D38@sourceware.org> (raw)

https://gcc.gnu.org/g:8b449dcd84334068c769a2f427812dadb95e61de

commit r13-2803-g8b449dcd84334068c769a2f427812dadb95e61de
Author: Marek Polacek <polacek@redhat.com>
Date:   Tue Sep 20 14:54:57 2022 -0400

    c++: ICE-on-invalid with designated initializer [PR106983]
    
    We ICE in the code added in r12-7117: type_build_dtor_call gets
    the error_mark_node because the type of 'prev' wasn't declared.
    
            PR c++/106983
    
    gcc/cp/ChangeLog:
    
            * typeck2.cc (split_nonconstant_init_1): Check TYPE_P.
    
    gcc/testsuite/ChangeLog:
    
            * g++.dg/other/error36.C: New test.

Diff:
---
 gcc/cp/typeck2.cc                    |  2 +-
 gcc/testsuite/g++.dg/other/error36.C | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/gcc/cp/typeck2.cc b/gcc/cp/typeck2.cc
index 688e9c15326..75fd0e2a9bf 100644
--- a/gcc/cp/typeck2.cc
+++ b/gcc/cp/typeck2.cc
@@ -597,7 +597,7 @@ split_nonconstant_init_1 (tree dest, tree init, bool last,
 		    if (prev == field_index)
 		      break;
 		    tree ptype = TREE_TYPE (prev);
-		    if (type_build_dtor_call (ptype))
+		    if (TYPE_P (ptype) && type_build_dtor_call (ptype))
 		      {
 			tree pcref = build3 (COMPONENT_REF, ptype, dest, prev,
 					     NULL_TREE);
diff --git a/gcc/testsuite/g++.dg/other/error36.C b/gcc/testsuite/g++.dg/other/error36.C
new file mode 100644
index 00000000000..556287816fd
--- /dev/null
+++ b/gcc/testsuite/g++.dg/other/error36.C
@@ -0,0 +1,13 @@
+// PR c++/106983
+// { dg-do compile { target c++20 } }
+
+typedef unsigned long long A;
+typedef union
+{
+  struct B s; // { dg-error "incomplete" }
+  A a;
+} U;
+void f (A x, unsigned int b)
+{
+  const U y = {.a = x};
+}

                 reply	other threads:[~2022-09-23  0:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220923002427.8E0403858D38@sourceware.org \
    --to=mpolacek@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).