public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Kewen Lin <linkw@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-2844] rs6000: Fix condition of define_expand vec_shr_<mode> [PR100645]
Date: Mon, 26 Sep 2022 03:24:05 +0000 (GMT)	[thread overview]
Message-ID: <20220926032405.C518E3858C52@sourceware.org> (raw)

https://gcc.gnu.org/g:bfad7069b74c97000b698191c1945f07a6192db5

commit r13-2844-gbfad7069b74c97000b698191c1945f07a6192db5
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Sun Sep 25 22:01:50 2022 -0500

    rs6000: Fix condition of define_expand vec_shr_<mode> [PR100645]
    
    PR100645 exposes one latent bug in define_expand vec_shr_<mode>
    that the current condition TARGET_ALTIVEC is too loose.  The
    mode iterator VEC_L contains a few modes, they are not always
    supported as vector mode, VECTOR_UNIT_ALTIVEC_OR_VSX_P should
    be used like some other VEC_L usages.
    
            PR target/100645
    
    gcc/ChangeLog:
    
            * config/rs6000/vector.md (vec_shr_<mode>): Replace condition
            TARGET_ALTIVEC with VECTOR_UNIT_ALTIVEC_OR_VSX_P.
    
    gcc/testsuite/ChangeLog:
    
            * gcc.target/powerpc/pr100645.c: New test.

Diff:
---
 gcc/config/rs6000/vector.md                 |  2 +-
 gcc/testsuite/gcc.target/powerpc/pr100645.c | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/gcc/config/rs6000/vector.md b/gcc/config/rs6000/vector.md
index a0d33d2f604..0171705803c 100644
--- a/gcc/config/rs6000/vector.md
+++ b/gcc/config/rs6000/vector.md
@@ -1475,7 +1475,7 @@
   [(match_operand:VEC_L 0 "vlogical_operand")
    (match_operand:VEC_L 1 "vlogical_operand")
    (match_operand:QI 2 "reg_or_short_operand")]
-  "TARGET_ALTIVEC"
+  "VECTOR_UNIT_ALTIVEC_OR_VSX_P (<MODE>mode)"
 {
   rtx bitshift = operands[2];
   rtx shift;
diff --git a/gcc/testsuite/gcc.target/powerpc/pr100645.c b/gcc/testsuite/gcc.target/powerpc/pr100645.c
new file mode 100644
index 00000000000..c4e92cc8052
--- /dev/null
+++ b/gcc/testsuite/gcc.target/powerpc/pr100645.c
@@ -0,0 +1,13 @@
+/* { dg-require-effective-target powerpc_altivec_ok } */
+/* { dg-options "-mdejagnu-cpu=power6 -maltivec" } */
+
+/* This used to ICE.  */
+
+typedef long long v2di __attribute__ ((vector_size (16)));
+
+v2di
+foo_v2di_l (v2di x)
+{
+  return __builtin_shuffle ((v2di){0, 0}, x, (v2di){3, 0});
+}
+

                 reply	other threads:[~2022-09-26  3:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926032405.C518E3858C52@sourceware.org \
    --to=linkw@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).