public inbox for gcc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Thomas Neumann <tneumann@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org
Subject: [gcc r13-2870] fix assert in __deregister_frame_info_bases
Date: Mon, 26 Sep 2022 13:12:17 +0000 (GMT)	[thread overview]
Message-ID: <20220926131217.3E5BB3858CDA@sourceware.org> (raw)

https://gcc.gnu.org/g:386ebf75f4c0342b1f823f4e4aba07abda3288d1

commit r13-2870-g386ebf75f4c0342b1f823f4e4aba07abda3288d1
Author: Thomas Neumann <tneumann@users.sourceforge.net>
Date:   Fri Sep 23 15:57:13 2022 +0200

    fix assert in __deregister_frame_info_bases
    
    When using the atomic fast path deregistering can fail during
    program shutdown if the lookup structures are already destroyed.
    The assert in __deregister_frame_info_bases takes that into
    account. In the non-fast-path case however is not aware of
    program shutdown, which caused a compiler error on such platforms.
    We fix that by introducing a constant for in_shutdown in
    non-fast-path builds.
    We also drop the destructor priority, as it is not supported on
    all platforms and we no longer rely upon the priority anyway.
    
    libgcc/ChangeLog:
            * unwind-dw2-fde.c: Introduce a constant for in_shutdown
            for the non-fast-path case. Drop destructor priority.

Diff:
---
 libgcc/unwind-dw2-fde.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libgcc/unwind-dw2-fde.c b/libgcc/unwind-dw2-fde.c
index d237179f4ea..3c0cc654ec0 100644
--- a/libgcc/unwind-dw2-fde.c
+++ b/libgcc/unwind-dw2-fde.c
@@ -51,7 +51,7 @@ static struct btree registered_frames;
 static bool in_shutdown;
 
 static void
-release_registered_frames (void) __attribute__ ((destructor (110)));
+release_registered_frames (void) __attribute__ ((destructor));
 static void
 release_registered_frames (void)
 {
@@ -67,6 +67,8 @@ static void
 init_object (struct object *ob);
 
 #else
+/* Without fast path frame deregistration must always succeed.  */
+static const int in_shutdown = 0;
 
 /* The unseen_objects list contains objects that have been registered
    but not yet categorized in any way.  The seen_objects list has had

                 reply	other threads:[~2022-09-26 13:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220926131217.3E5BB3858CDA@sourceware.org \
    --to=tneumann@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).